Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sizes are forced to 1em #59

Open
hdwebpros opened this issue Jun 25, 2024 · 1 comment
Open

Sizes are forced to 1em #59

hdwebpros opened this issue Jun 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@hdwebpros
Copy link

Sizes are forced to 1em. Yes, I treat this as a bug.

I understand that it may be a bit simpler for someone to import the module and not worry about using icons and writing two lines of CSS or adding an HTML class to dictate size. It may save that one step.

Given how powerful Nuxt is, I don't see this as much of an added value. It's so easy to add an HTML class or SCSS or CSS that forcing width and height doesn't save you much.

This does create some headaches though. What if icons need to be one size on one page, but a different size on another? Too bad! What if they need to be something different than 1em? You're writing CSS or SCSS anyways. What if we are using Tailwind? Nope, can't add classes to override, the forced 1em width overrides that. You'd have to add custom tailwind with !important tags.

There should be a setting in the module to not force this width. That's the easiest solution IMO. In fact, a perfect world there'd be an option to disable the forced size and an option to set the size to whatever you want, but I recommend the option to disable the forced size.

@hdwebpros hdwebpros added the bug Something isn't working label Jun 25, 2024
@rowild
Copy link

rowild commented Nov 3, 2024

Actually, !important does not either. Also not a more precise nesting or scoping. Trying to do so since 2 days, without success...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants