Tree view breaks on deep folder trees

[gitblit]

Originally reported on Google Code with ID 35

I notice that forward slashes in links in tree view are replaced by %2F

Even if I manually replace %2F with a forward slash, I still am not able to view the
tree as am taken back to the original folder. See the attached screenshots for more
details


Am running Gitblit v0.7.0
Server: Red Hat Enterprise Linux 6
Kernel: 2.6.32-71.el6.i686
Java version: 1.7.0_02
Java vendor: Sun Microsystems
Web Server: Glassfish version 3.1.1

Reported by arthurbuliva on 2012-01-05 08:54:29

---

- _Attachment: Screenshot at 2012-01-05 10:14:35.png
_ - _Attachment: Screenshot at 2012-01-05 10:15:03.png
_ - _Attachment: Screenshot at 2012-01-05 10:15:28.png
_

[gitblit]

%2F is correct - that is an url encoded forward-slash.  Replacing it with a plain forward-slash
will definitely not work.  I have not tested on Glassfish.  Some servlet containers
(like Tomcat) disallow embedded forward-slashes by default.  Glassfish may also fall
into that category.  Your screenshots also indicate there may be a proxy layer involved.
 Proxies often re-encode %2F as / or vice-versa so that could be another problem point.

I would recommend trying a few different changes to see what works best for you:

1. set web.mountParameters = false in web.xml. This will replace the pretty URLs with
parameterized URLs and is likely to fix your problem.

2. set web.forwardSlashCharacter = ! in web.xml.  This will replace embedded '/' with
'!'.  If you go with choice 1, choice 2 does not offer you anything.  If you want to
keep pretty urls, try this one.

3. Investigate Glassfish and/or proxy layer to understand it's position on embedded
forward-slashes in URLs.

BTW, these are screenshots of 0.6.0, not 0.7.0.

Reported by James.Moger on 2012-01-05 13:07:12

[gitblit]

web.mountParameters = false  has solved the issue, thanks. I really don't mind the clean
urls as long as the app is working. Am happy :-)

Yes I agree that the screenshots are for v6 but yes even v7 had the same issue

Just also to mention that keep up the good work. Gitblit is the first practical git
web interface I have managed to set up that actually works for me.

PS I like the interface that v7 has. Looks really pretty

Reported by arthurbuliva on 2012-01-06 04:47:34

[gitblit]

I'm glad everything is working for you now and thanks for the feedback!
Look for v0.8.0 sometime next week.

Reported by James.Moger on 2012-01-06 13:14:36

• Status changed: Done