fix: fixed avg contribution calc + NaN state display on Manager

[ArslanYM]

Description

The Avg. Contribution text will display N/A insted of NaN when round && round.uniqueContributors is not > 0 otherwise the same functionality as before.

Refers/Fixes

This PR fixes #1541

Testing

Tested this on my local server.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
builder	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2023 11:21am
explorer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2023 11:21am
manager	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2023 11:21am

[vercel]

@ArslanYM is attempting to deploy a commit to the Grants Stack Team on Vercel.

A member of the Team first needs to authorize it.

[gitstream-cm]

🥷 Code experts: vacekj, boudra

vacekj, boudra have most 👩‍💻 activity in the files.
vacekj, boudra have most 🧠 knowledge in the files.

See details

packages/round-manager/src/features/round/ViewRoundStats.tsx

Activity based on git-commit:

	vacekj	boudra
SEP
AUG	5 additions & 2 deletions
JUL
JUN
MAY	1 additions & 1 deletions	18 additions & 11 deletions
APR	11 additions & 47 deletions	112 additions & 174 deletions

Knowledge based on git-blame:
vacekj: 58%
boudra: 36%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

This PR is 47.368421052631575% new code.

[bard]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).

It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.

This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.

Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

[ArslanYM]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).

It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.

This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.

Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

Sure thing. On it.

[ArslanYM]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).

It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.

This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.

Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

The solution you asked to try doesn't seem to work.

[bard]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).
It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.
This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.
Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

The solution you asked to try doesn't seem to work.

Could you give it another try, place .prettierrc.json in packages/round-manager instead of the project root, and see if that gets picked out?

If that also doesn't work, we'll merge the PR as-is.

[ArslanYM]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).
It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.
This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.
Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

The solution you asked to try doesn't seem to work.

Could you give it another try, place .prettierrc.json in packages/round-manager instead of the project root, and see if that gets picked out?

If that also doesn't work, we'll merge the PR as-is.

Tried that as well. Doesn't seem to work.

[ArslanYM]

Hey @ArslanYM, there is some diff noise in the patch, i.e. changes in formatting only (line 53 and line 156-157).
It's no big deal in a change this small, but on a bigger one, it would obscure the real changes and put the reviewer at risk of missing something important.
This is probably due to the fact that our project doesn't have a .prettierrc.json, so your IDE is using its local settings.
Could you try copying .prettierrc.json from https://github.com/gitcoinco/allo-indexer/ into your local grants-stack worktree root, save packages/round-manager/src/features/round/ViewRoundStats.tsx again, and see if it respects the formatting of the original?

The solution you asked to try doesn't seem to work.

Could you give it another try, place .prettierrc.json in packages/round-manager instead of the project root, and see if that gets picked out?
If that also doesn't work, we'll merge the PR as-is.

Tried that as well. Doesn't seem to work.

I'll be careful about this next time. Apologies.

[bard]

I'll be careful about this next time. Apologies.

Sorry, I wasn't clear in my explanation, this is none of your fault, rather a bug in our project setup, as it should already include a prettierrc already and ideally autoformat every commit through git hooks (in fact, we have an in-progress PR for this at #2314).

We're currently sorting some build issues and we'll merge this and your other PRs after that. Thanks again for contributing!