Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Add additional provider names to types #9

Closed
shavinac opened this issue Jul 5, 2022 · 0 comments · Fixed by #14
Closed

[types] Add additional provider names to types #9

shavinac opened this issue Jul 5, 2022 · 0 comments · Fixed by #14
Assignees

Comments

@shavinac
Copy link
Contributor

shavinac commented Jul 5, 2022

https://github.com/gitcoinco/passport-sdk/blob/1b30f28575b1f6fe5a35fe400265775b4be15317/packages/types/src/index.d.ts#L122

Gitcoin Passport now supports additional providers like "Brightid" | "Github" (see https://github.com/gitcoinco/dPopp/blob/main/types/src/index.d.ts#L125)

We should also consider accepting any string for the passport-sdk PROVIDER_ID type, to allow other developers to easily use their own applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant