Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'my projects' tab should be greyed out if user is not logged in #769

Closed
owocki opened this issue Apr 2, 2018 · 7 comments · Fixed by #10981
Closed

'my projects' tab should be greyed out if user is not logged in #769

owocki opened this issue Apr 2, 2018 · 7 comments · Fixed by #10981
Labels
enhancement This is a feature to be enhanced or improved.

Comments

@owocki
Copy link
Contributor

owocki commented Apr 2, 2018

Actual Functionality

screenshot

Clicking these radio buttons doesnt work when the user is not logged in, in that the search results are always empty.

Expected Functionality

When I am not logged in, these radio buttons should be disabled and there should be a prompt for the user to login.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH (19.26 USD @ $385.18/ETH) has been granted to @owocki for this issue from Mitchell Adam Kosowski IV. ⚡️

The sender had the following public comments:

Good catch :) and testing sending tips per #760

Nice work @owocki! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@thelostone-mc
Copy link
Member

Oh shoot @kziemianek did not see your PR 😅

@thelostone-mc
Copy link
Member

thelostone-mc commented Apr 2, 2018

@PixelantDesign could you check out @kziemianek , if it looks solid -> I'll shut mine down ^_^

@PixelantDesign
Copy link
Contributor

If user is not logged in, lets completely hide my projects filter.

@thelostone-mc
Copy link
Member

thelostone-mc commented Apr 2, 2018

@kziemianek If we are hiding it entirely -> This one is yours! You did shoot out the PR before me. ^_^

@kziemianek
Copy link
Contributor

@thelostone-mc sorry, should have posted that I'm working on this.
Updated PR according to @PixelantDesign comment.

@mbeacom mbeacom added the enhancement This is a feature to be enhanced or improved. label Apr 2, 2018
@owocki owocki closed this as completed Apr 4, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH (18.72 USD @ $374.31/ETH) has been granted to @kziemiane for this issue from Kevin. ⚡️

The sender had the following public comments:

Its been great having you around to steward the repos :)

Nice work @kziemiane! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature to be enhanced or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants