Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters: enable MY Projects filter only for logged in users #772

Closed
wants to merge 1 commit into from

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 2, 2018

Description

If the user hasn't logged in, the while My Projects tab is clickable with the gitcoin icon that encourages folks to login to github.
Post that , the page refreshes -> and the filters appear as usual

x

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
Fixes

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Apr 2, 2018

Could throw in a tooltip there if needed to state login to github to use these filters
@PixelantDesign @owocki

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   33.95%   33.95%           
=======================================
  Files         101      101           
  Lines        5695     5695           
  Branches      666      666           
=======================================
  Hits         1934     1934           
  Misses       3685     3685           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe363df...9144416. Read the comment docs.

@thelostone-mc
Copy link
Member Author

Closing in favor of #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants