disable my projects filters if user not logged in #771
Conversation
|
Alert preview:
|
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 33.94% 33.94%
=======================================
Files 101 101
Lines 5697 5697
Branches 667 667
=======================================
Hits 1934 1934
Misses 3686 3686
Partials 77 77Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Per @PixelantDesign's comment on the source issue: #769 (comment)
Would you mind updating this to hide the My Projects filter all together if the user isn't logged in?
| @@ -61,6 +61,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| {% if github_handle is not False %} | |||
There was a problem hiding this comment.
{% if github_handle %} should suffice ^_^
| @@ -82,6 +83,7 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
Could we we indent this component by 1 ?
( Cause it's within an if condition )
There was a problem hiding this comment.
yes, my formatting tool doesnt recognize this syntax.
|
Also could we squash the commits into one commit ? |
kziemianek
force-pushed
the
disabled_my_projects_filters
branch
from
f5740e4
to
9b247ae
Compare
|
@thelostone-mc I though commits can be squashed just before merge by GitHub. |
|
@mbeacom this looks good for merge 👍 |
Description
If user is not logged in, my projects filters are disabled.
Checklist
Affected core subsystem(s)
frontend
Testing
tested manually
Refers/Fixes
Refs: #769