Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: updated styling + linting #1266

Merged
merged 2 commits into from
May 25, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

Description
  • fonts now use Muli
  • removed + refactored + reindented html
  • optimized view for mobile

x1

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css + html

Fixes

@SaptakS should I change them to rem ? :P

- fonts now use Muli
- removed + refactored + reindented html
- optimized view for mobile

Fixes: gitcoinco#1261
@thelostone-mc thelostone-mc self-assigned this May 25, 2018
@ghost ghost added the in progress label May 25, 2018
@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #1266 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
- Coverage   31.37%   31.33%   -0.04%     
==========================================
  Files         120      120              
  Lines        8320     8320              
  Branches     1083     1083              
==========================================
- Hits         2610     2607       -3     
- Misses       5601     5604       +3     
  Partials      109      109
Impacted Files Coverage Δ
app/app/settings.py 83.61% <0%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e029f4c...b2110e7. Read the comment docs.

@ghost ghost assigned mbeacom May 25, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit a746c2b into gitcoinco:master May 25, 2018
@ghost ghost removed the in progress label May 25, 2018
@thelostone-mc thelostone-mc deleted the css branch May 25, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants