Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS: Ensure 10%+ gas minimum #1303

Merged
merged 5 commits into from
May 30, 2018
Merged

ENS: Ensure 10%+ gas minimum #1303

merged 5 commits into from
May 30, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented May 29, 2018

Description

The goal of this PR is to resolve: #1302 (https://rollbar.com/gitcoin/gitcoin/items/1176/)
Explanation of fix

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

ens

Refers/Fixes

Fix #1302

@mbeacom mbeacom added bug This is something that isn't working as intended. backend This needs backend expertise. labels May 29, 2018
@mbeacom mbeacom self-assigned this May 29, 2018
@mbeacom mbeacom requested a review from owocki May 29, 2018 06:39
@ghost ghost added the in progress label May 29, 2018
@mbeacom mbeacom changed the title Ensure 10%+ gas minimum and catch exception ENS: Ensure 10%+ gas minimum and catch exception May 29, 2018
@mbeacom mbeacom changed the title ENS: Ensure 10%+ gas minimum and catch exception ENS: Ensure 10%+ gas minimum May 29, 2018
@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #1303 into master will increase coverage by 0.96%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   31.29%   32.26%   +0.96%     
==========================================
  Files         122      123       +1     
  Lines        8521     9132     +611     
  Branches     1116     1287     +171     
==========================================
+ Hits         2667     2946     +279     
- Misses       5743     6065     +322     
- Partials      111      121      +10
Impacted Files Coverage Δ
.../enssubdomain/management/commands/reprocess_txs.py 0% <ø> (ø) ⬆️
...management/commands/warn_when_wallet_out_of_eth.py 0% <ø> (ø) ⬆️
app/enssubdomain/admin.py 100% <100%> (ø) ⬆️
app/enssubdomain/utils.py 100% <100%> (ø)
app/enssubdomain/views.py 23.4% <28%> (+0.09%) ⬆️
app/enssubdomain/models.py 58.82% <40%> (ø) ⬆️
app/app/urls.py 90.24% <0%> (-4.05%) ⬇️
app/dashboard/router.py 34.65% <0%> (-2.43%) ⬇️
app/dashboard/models.py 59.27% <0%> (-0.52%) ⬇️
app/app/settings.py 85.22% <0%> (-0.09%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfbbc7...554e6b2. Read the comment docs.

# to "0x7bce7e4bcd2fea4d26f3d254bb8cf52b9ee8dd7353b19bfbc86803c27d9bbf39"
txn_hash = str(binascii.b2a_hex(txn_hash)).replace("b'", "0x").rstrip("'")
except ValueError:
logger.warning('Error in set_address_at_resolver')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not log the exception too?

owocki
owocki previously approved these changes May 29, 2018
@mbeacom mbeacom merged commit 8f0fa37 into master May 30, 2018
@ghost ghost removed the in progress label May 30, 2018
@mbeacom mbeacom deleted the mark-catch-1302 branch May 30, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. bug This is something that isn't working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: {'code': -32000, 'message': 'replacement transaction underpriced'}
2 participants