Add user search autocomplete #2108

octavioamu · 2018-08-27T18:58:52Z

Description

Add autocomplete typeahead features for usernames
Fix select2 sizes

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

UI

Testing

Refers/Fixes

Fixes: #2001

stickler-ci · 2018-08-27T19:01:27Z

app/assets/onepager/js/send.js

@@ -66,12 +66,14 @@ $(document).ready(function() {
    if ($(this).hasClass('disabled'))
      return;
    loading_button($(this));
-
+    console.log('dentro')


Missing semicolon. (semi)

stickler-ci · 2018-08-27T19:01:27Z

app/assets/onepager/js/send.js

    // get form data
    var email = $('#email').val();
    var github_url = $('#issueURL').val();
    var from_name = $('#fromName').val();
-    var username = $('#username').val();
+    // var username = $('#username').val();
+    var username = $('.username-search').select2('data')[0].text


Expected blank line after variable declarations. (newline-after-var)
Missing semicolon. (semi)

stickler-ci · 2018-08-27T19:01:27Z

app/assets/onepager/js/send.js

-    var username = $('#username').val();
+    // var username = $('#username').val();
+    var username = $('.username-search').select2('data')[0].text
+    console.log(username)


Missing semicolon. (semi)

stickler-ci · 2018-08-27T19:01:28Z

app/assets/v2/js/user-search.js

+      url: '/api/v0.1/users_search/',
+      dataType: 'json',
+      delay: 250,
+      data: function (params) {


Unexpected space before function parentheses. (space-before-function-paren)

stickler-ci · 2018-08-27T19:01:28Z

app/assets/v2/js/user-search.js

+      dataType: 'json',
+      delay: 250,
+      data: function (params) {
+        var query = {


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-08-27T19:01:30Z

app/assets/v2/js/user-search.js

+    minimumInputLength: 3,
+    escapeMarkup: function (markup) { return markup; }, // let our custom formatter work
+    templateResult: formatUser,
+    templateSelection: formatUserSelection,


Unexpected trailing comma. (comma-dangle)

stickler-ci · 2018-08-27T19:01:30Z

app/assets/v2/js/user-search.js

+    // theme: "bootstrap4"
+  });
+
+  function formatUser (user) {


Unexpected space before function parentheses. (space-before-function-paren)

stickler-ci · 2018-08-27T19:01:31Z

app/assets/v2/js/user-search.js

+    return markup;
+  }
+
+  function formatUserSelection (user) {


Unexpected space before function parentheses. (space-before-function-paren)

stickler-ci · 2018-08-27T19:01:31Z

app/assets/v2/js/user-search.js

+    if (user.id) {
+      var selected = `<img class="rounded-circle" src="${user.avatar_url || static_url + 'v2/images/user-placeholder.png'}" width="20" height="20"/> ${user.text}`;
+    }
+    return selected || user.text;


'selected' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-08-27T19:01:32Z

app/dashboard/views.py

+    else:
+        data = 'fail'
+    mimetype = 'application/json'
+    return HttpResponse(data, mimetype)


W292 no newline at end of file

I can't understand in my file is an empty last line

stickler-ci · 2018-08-27T19:17:44Z

app/assets/v2/js/user-search.js

+      delay: 250,
+      data: function(params) {
+
+        var query = {


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-08-27T19:17:44Z

app/assets/v2/js/user-search.js

+      data: function(params) {
+
+        var query = {
+          term: params.term,


Unexpected trailing comma. (comma-dangle)

stickler-ci · 2018-08-27T19:17:45Z

app/assets/v2/js/user-search.js

+
+        var query = {
+          term: params.term,
+        }


Missing semicolon. (semi)

stickler-ci · 2018-08-27T19:17:45Z

app/assets/v2/js/user-search.js

+      },
+      processResults: function(data) {
+        return {
+          results: data,  


Unexpected trailing comma. (comma-dangle)
Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-08-27T19:17:45Z

app/assets/v2/js/user-search.js

+    },
+    placeholder: 'Search by username',
+    minimumInputLength: 3,
+    escapeMarkup: function(markup) { 


Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-08-27T19:17:46Z

app/assets/v2/js/user-search.js

+    minimumInputLength: 3,
+    escapeMarkup: function(markup) { 
+
+      return markup; 


Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2018-08-27T19:17:46Z

app/assets/v2/js/user-search.js

+
+  function formatUserSelection(user) {
+    if (user.id) {
+      var selected = `<img class="rounded-circle" src="${user.avatar_url || static_url + 'v2/images/user-placeholder.png'}" width="20" height="20"/> ${user.text}`;


'selected' used outside of binding context. (block-scoped-var)

stickler-ci · 2018-08-27T19:17:46Z

app/assets/v2/js/user-search.js

+    if (user.id) {
+      var selected = `<img class="rounded-circle" src="${user.avatar_url || static_url + 'v2/images/user-placeholder.png'}" width="20" height="20"/> ${user.text}`;
+    } else {
+      var selected = user.text


'selected' is already defined. (no-redeclare)
'selected' used outside of binding context. (block-scoped-var)
Missing semicolon. (semi)

stickler-ci · 2018-08-27T19:17:46Z

app/assets/v2/js/user-search.js

+    } else {
+      var selected = user.text
+    }
+    return selected;


'selected' used outside of binding context. (block-scoped-var)

thelostone-mc · 2018-08-27T19:22:37Z

@octavioamu could we

replace var with let to suppress the linting errors
fix the remaining linting errors
rebase & resolve conflicts

eslint: fix

…ioamu/web into feature/autocomplete-users

stickler-ci · 2018-08-27T20:10:47Z

app/assets/v2/js/user-search.js

+    if (user.loading) {
+      return user.text;
+    }
+    let markup = `<div class="d-flex align-items-baseline">


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-08-27T20:10:48Z

app/assets/v2/js/user-search.js

+  }
+
+  function formatUserSelection(user) {
+    let selected;


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-08-27T20:10:48Z

app/assets/v2/js/user-search.js

+    if (user.id) {
+      selected = `<img class="rounded-circle" src="${user.avatar_url || static_url + 'v2/images/user-placeholder.png'}" width="20" height="20"/> ${user.text}`;
+    } else {
+      selected = user.text


Missing semicolon. (semi)

stickler-ci · 2018-08-27T20:10:48Z

app/dashboard/views.py

@@ -1557,3 +1557,25 @@ def change_bounty(request, bounty_id):
        'result': result
    }
    return TemplateResponse(request, 'bounty/change.html', params)
+
+


W293 blank line contains whitespace

codecov · 2018-08-27T20:46:54Z

Codecov Report

Merging #2108 into master will decrease coverage by 0.03%.
The diff coverage is 10%.

@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
- Coverage   27.91%   27.87%   -0.04%     
==========================================
  Files         136      136              
  Lines       11130    11149      +19     
  Branches     1499     1502       +3     
==========================================
+ Hits         3107     3108       +1     
- Misses       7913     7931      +18     
  Partials      110      110

Impacted Files	Coverage Δ
app/app/urls.py	`84.09% <ø> (ø)`	⬆️
app/dashboard/views.py	`13.77% <10%> (-0.23%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd59db...c70e19e. Read the comment docs.

stickler-ci · 2018-08-27T20:48:29Z

app/assets/v2/js/user-search.js

+
+  function formatUserSelection(user) {
+
+    let selected;


Expected blank line after variable declarations. (newline-after-var)

stickler-ci · 2018-08-27T20:48:29Z

app/dashboard/views.py

@@ -1,4 +1,4 @@
-# -*- coding: utf-8 -*-
+ # -*- coding: utf-8 -*-


E114 indentation is not a multiple of four (comment)
E116 unexpected indentation (comment)

thelostone-mc · 2018-08-28T11:38:49Z

@octavioamu I fixed the errors 😂

thelostone-mc

LGTM

SaptakS · 2018-08-28T12:33:17Z

app/dashboard/views.py

+            results.append(profile_json)
+        data = json.dumps(results)
+    else:
+        data = 'fail'


What happens when this block of code gets executed? Won't the formatUser fail? Secondly, if you are sending it with application/json, I think it is better to send something like {message: 'fail'}

thelostone-mc · 2018-08-28T14:28:19Z

app/dashboard/templates/onepager/send2.html

-      {% trans "To Github Username" %}:
-      <input type="text" placeholder="@username" id="username" value="" style="max-width: 400px; margin-left: auto; margin-right: auto;">
+      <label for="">{% trans "To Github Username" %}:</label> <br>
+      <!-- <input type="text" placeholder="@username" id="username" value="" style="max-width: 400px; margin-left: auto; margin-right: auto;"> -->


@octavioamu could we remove this if it's not being used ?

…ioamu/web into feature/autocomplete-users

octavioamu · 2018-08-28T16:36:35Z

Now looks like worked, not sure what bug is getting github but my branch was diff than this one and the changes wasn't being shown here, now all the changes appears. I was getting crazy....
@SaptakS I had changed the code, if a request is not ajax 404 page is shown and not a new page with a text message.
@thelostone-mc removed the commented code

mbeacom · 2018-08-28T16:56:11Z

@octavioamu Seems there is some latency picking up changes on GH today.

octavioamu and others added 3 commits August 27, 2018 15:06

Add user search autocomplete

d34ab50

eslint: fix

fed7bf1

fix username send

bcd2c72

stickler-ci reviewed Aug 27, 2018

View reviewed changes

clean code

b00b6e2

stickler-ci reviewed Aug 27, 2018

View reviewed changes

thelostone-mc requested review from thelostone-mc and SaptakS August 27, 2018 19:23

thelostone-mc mentioned this pull request Aug 27, 2018

BUILD - Reserve Bounties #2037

Closed

6 tasks

owocki and others added 6 commits August 27, 2018 13:46

Merge pull request gitcoinco#2107 from thelostone-mc/crowd

b3cfa17

eslint: fix

Add user search autocomplete

8bd1eac

fix username send

89b1402

clean code

a033fdc

trim spaces

44cb032

Merge branch 'feature/autocomplete-users' of https://github.com/octav…

dc4d9d2

…ioamu/web into feature/autocomplete-users

stickler-ci reviewed Aug 27, 2018

View reviewed changes

octavioamu added 2 commits August 27, 2018 17:23

add new line

b3c5d07

fix code stickler-ci

a2ba97c

stickler-ci reviewed Aug 27, 2018

View reviewed changes

lint fixes

880a572

css: removed comments

719183e

thelostone-mc previously approved these changes Aug 28, 2018

View reviewed changes

SaptakS reviewed Aug 28, 2018

View reviewed changes

thelostone-mc reviewed Aug 28, 2018

View reviewed changes

octavioamu added 3 commits August 28, 2018 12:57

Add user search autocomplete

12d5a97

fix username send

a5f5850

clean code

b9b6b85

octavioamu added 10 commits August 28, 2018 12:59

Add user search autocomplete

22f0934

fix username send

eba0c76

clean code

76a469c

trim spaces

c2f42c4

add new line

9a7bd48

fix code stickler-ci

c87d78d

satisfy stickler-ci

5883a95

404 for not ajax request

71f4d2b

Merge branch 'feature/autocomplete-users' of https://github.com/octav…

30ce720

…ioamu/web into feature/autocomplete-users

update packages

360214b

octavioamu dismissed thelostone-mc’s stale review via 360214b August 28, 2018 16:31

thelostone-mc previously approved these changes Aug 28, 2018

View reviewed changes

removed leading @ for autocomplete

c70e19e

thelostone-mc dismissed their stale review via c70e19e August 29, 2018 10:52

thelostone-mc approved these changes Aug 29, 2018

View reviewed changes

thelostone-mc merged commit 44cfa66 into gitcoinco:master Aug 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add user search autocomplete #2108

Add user search autocomplete #2108

octavioamu commented Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

octavioamu Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

thelostone-mc commented Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

codecov bot commented Aug 27, 2018 •

edited

Loading

stickler-ci Aug 27, 2018

stickler-ci Aug 27, 2018

thelostone-mc commented Aug 28, 2018

thelostone-mc left a comment

SaptakS Aug 28, 2018

thelostone-mc Aug 28, 2018

octavioamu commented Aug 28, 2018

mbeacom commented Aug 28, 2018

		@@ -1,4 +1,4 @@
		# -- coding: utf-8 --
		# -- coding: utf-8 --

Add user search autocomplete #2108

Add user search autocomplete #2108

Conversation

octavioamu commented Aug 27, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc commented Aug 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 27, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thelostone-mc commented Aug 28, 2018

thelostone-mc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octavioamu commented Aug 28, 2018

mbeacom commented Aug 28, 2018

codecov bot commented Aug 27, 2018 •

edited

Loading