[WOC] Wagtail - Developer & Funder Guides #2130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2130 +/- ##
=========================================
+ Coverage 29.79% 29.89% +0.1%
=========================================
Files 180 181 +1
Lines 13722 13742 +20
Branches 1840 1840
=========================================
+ Hits 4088 4108 +20
Misses 9496 9496
Partials 138 138
Continue to review full report at Codecov.
|
| 'bounty_requests', | ||
|
|
||
| # wagtail | ||
| 'taggit', |
There was a problem hiding this comment.
Should we include TAGGIT_CASE_INSENSITIVE = env.bool('TAGGIT_CASE_INSENSITIVE', default=True) somewhere in the settings?
There was a problem hiding this comment.
That's a good idea
|
@mbeacom I resolved your comments 👍 |
pinkiebell
changed the title
|
Final update. The images must be uploaded & added later on production with wagtail. |
|
|
||
|
|
||
| class GuidePage(Page): | ||
| """Defines the structure for the GuidePage.""" |
There was a problem hiding this comment.
@pinkiebell Generally, looks good. Going to throw this on staging.
Random note regarding docstrings/spacing with pep-257/258:
Classes call for a blank line like so:
class Class:
"""Some class docstring."""
var = 'derp'Methods:
def derp():
"""Some derp method."""
var = 'derp'Some other spacing notes all together:
from __future__ import braces
class Derp:
"""Derp docstring."""
def derp(self):
"""Some Derp.derp class method docstring."""
var = 'derp'
def derp2(self):
"""Some Derp.derp2 class method docstring."""
var = 'derp2'
def derp(self):
"""Some derp method docstring."""
var = 'derp'
def derp2(self):
"""Some derp2 method docstring."""
var = 'derp2'Also, when possible, we follow the google style pep-257/258 docstrings:
def derp(dingo, dance='tango'):
"""Handle processing a dingo based on the provided dance.
Args:
dingo (dashboard.Derp): The Derp object.
dance (str): The dance type. Defaults to: tango.
Returns:
bool: Whether or not the Derp performs the specified dance.
"""
return dance in dingo.known_dances
|
Seeing this on staging at: https://stage.gitcoin.co/cms/pages/ Is there something I should adjust here? Migrations have ran successfully and fixtures have been imported. |
|
@mbeacom |
|
@pinkiebell We have a pk=1 user, but it's not a superuser... That was while I was logged in with my standard user (mbeacom) with |
|
@mbeacon |
|
@mbeacom |
|
Quick rebase. I tried both with a purged web_pgdata & and with a backup against latest master. |
|
@pinkiebell any updates on this or questions from your end on @mbeacom comments? |
|
@PixelantDesign |
|
@mbeacom Ready for a spin 👍 |
To import initial pages: ``` docker-compose exec web bash cd app && cat cms/fixtures/guides.json|./manage.py loaddata --format json - ``` NOTE: The fixture data does not include media files, so the pages needs to be fixed. Fixes #1860
|
@mbeacom So that needs to be manually fixed 💥 .
|
|
Ah, and the administration page doesn't help much because |
|
did some QA on this today
@pinkiebell looking forward to seeing this work! FWIW, it was working pretty well before i loaded the fixtures.. |
|
@owocki I will check the alignment of the header and I guess @mbeacom has to manually inject the data... |
|
@pinkiebell how do you plan to insert the data if not with fixtures? can u have me a SQL dump? screenshot of the alignment issues here: |
| @@ -402,6 +405,11 @@ | |||
| # gitcoinbot | |||
| url(settings.GITHUB_EVENT_HOOK_URL, gitcoinbot.views.payload, name='payload'), | |||
| url(r'^impersonate/', include('impersonate.urls')), | |||
|
|
|||
| # wagtail | |||
| re_path(r'^cms/', include(wagtailadmin_urls)), | |||
There was a problem hiding this comment.
@pinkiebell
two questions:
- is there any public facing index of all of the helpdesk items we can use?
- is there any way to get the helpdesk items into the sitemap (see sitemaps.py)
There was a problem hiding this comment.
- That would have to be built. It is also possible to redirect to a custom page in the meantime.
- Wagtail has a sitemap module; that should work.
A sql dump is useless in this case too. For more background: wagtail/wagtail#1366 |
mbeacom
changed the title
mbeacom
changed the title
There was a problem hiding this comment.
@pinkiebell this looks _amazing.. thank you!
@mbeacom ok to 🚢 from your perspective?
|
hey @pinkiebell im trying to deploy these live now and i keep getting error when i try to publish them screenshot : http://bits.owocki.com/ba98fa2a9be8/Screen%20Shot%202018-12-04%20at%203.03.12%20PM.png |
|
@owocki |
|
@owocki |
|
@pinkiebell how do i get to the live pages once they're published'. the links all seem to be broken to me - screencast |
|
also note it says "There is no site set up for this location. Pages created here will not be accessible at any URL until a site is associated with this location. Configure a site now." even though i do have a site setup |
|
@owocki |
To import initial pages:
NOTE: The fixture data does not include media files, so the pages needs to be fixed.
Fixes #1860