Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes featuring date logic in js #3914

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Mar 7, 2019

Description

Fixes featuring date logic in JS

Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
  • Read and followed the Contributor Guidelines
  • Tested all changes locally
  • Verified existing functionality
  • Ran make test and everything passed!
Reviewer
  • Affirm contributor guidelines have been followed and requested changes made
  • CI tests and linting pass
  • No conflicts (migrations, files, etc)
  • Regression tested against staging or local deployment
Funder
  • Validated requested changes were made to specification
  • Bounty payout released to the contributor

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #3914 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3914      +/-   ##
==========================================
- Coverage   30.23%   30.18%   -0.06%     
==========================================
  Files         203      203              
  Lines       15861    15861              
  Branches     2088     2088              
==========================================
- Hits         4796     4788       -8     
- Misses      10890    10901      +11     
+ Partials      175      172       -3
Impacted Files Coverage Δ
app/dashboard/utils.py 35.2% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6787e22...047e7d1. Read the comment docs.

octavioamu
octavioamu previously approved these changes Mar 7, 2019
@octavioamu octavioamu merged commit a2ba894 into gitcoinco:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants