Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show kudos in bounty activity #3949

Merged
merged 4 commits into from
Mar 23, 2019
Merged

Show kudos in bounty activity #3949

merged 4 commits into from
Mar 23, 2019

Conversation

usmanmuhd
Copy link
Contributor

Fixes #3014

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #3949 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3949      +/-   ##
=========================================
+ Coverage   29.97%     30%   +0.03%     
=========================================
  Files         203     203              
  Lines       15904   15911       +7     
  Branches     2093    2093              
=========================================
+ Hits         4767    4774       +7     
  Misses      10967   10967              
  Partials      170     170
Impacted Files Coverage Δ
app/dashboard/router.py 29.62% <100%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbdb3e...afcb488. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #3949 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3949      +/-   ##
==========================================
+ Coverage   30.11%   30.14%   +0.03%     
==========================================
  Files         205      205              
  Lines       16028    16035       +7     
  Branches     2115     2115              
==========================================
+ Hits         4827     4834       +7     
  Misses      11027    11027              
  Partials      174      174
Impacted Files Coverage Δ
app/dashboard/router.py 28.23% <100%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746c2bf...595b9ba. Read the comment docs.

@thelostone-mc
Copy link
Member

CI fixes + Rebase with master + Recording needed

@usmanmuhd usmanmuhd force-pushed the activity-fix branch 4 times, most recently from 6856eb3 to ac2b18d Compare March 13, 2019 03:09
@usmanmuhd
Copy link
Contributor Author

Fixed the above. Got this:
image

Not sure on how to make the text on same line as image.

octavioamu
octavioamu previously requested changes Mar 15, 2019
View reviewed changes
app/dashboard/templates/bounty/details.html Outdated Show resolved Hide resolved
@gitcoinbot gitcoinbot mentioned this pull request Mar 23, 2019
Closed
@thelostone-mc
Copy link
Member

@usmanmuhd A margin-top: auto , margin-bottom: auto would probably fix it to get it to the same line

@usmanmuhd
Copy link
Contributor Author

@thelostone-mc I made changes suggested to me by @octavioamu.
Screenshot:
image

@thelostone-mc thelostone-mc merged commit fdf9c6b into gitcoinco:master Mar 23, 2019
@usmanmuhd usmanmuhd deleted the activity-fix branch March 23, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu left review comments

@thelostone-mc thelostone-mc thelostone-mc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usmanmuhd @thelostone-mc @octavioamu