Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get Faucet Page across the finish line #407

Closed
wants to merge 25 commits into from
Closed

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Feb 13, 2018

This is a continuation of #211 and #258 (thanks @usulix ) meant to deliver the scope for #184

TODOS

  • - Migrated to python3
  • - Cleanup design, Add design from Code Faucet Page #184
  • - Update the 'github profile' field to populate from the github login (top right).
  • - Test end to end

@owocki owocki changed the title (WIP) new Faucet Page (WIP) get new Faucet Page across the finish line Feb 13, 2018
This was referenced Feb 13, 2018
@owocki owocki changed the title (WIP) get new Faucet Page across the finish line get Faucet Page across the finish line Feb 13, 2018
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.08 ETH (74.21 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $13294.2 more Funded OSS Work Available at: https://gitcoin.co/explorer

@KennethAshley
Copy link
Contributor

@owocki what is getting this across the line? Was the faucet ever successful?

@tanmayanand44
Copy link

@owocki Please guide a little.What to do here?

@gitcoinbot
Copy link
Member

Work has been started on the 0.08 ETH (76.95 USD) funding by:

  1. @KennethAshley

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@KennethAshley KennethAshley mentioned this pull request Feb 17, 2018
3 tasks
@gitcoinbot
Copy link
Member

Work for 0.08 ETH (77.13 USD) has been submitted by:

  1. @KennethAshley

Submitters, please leave a comment to let the funder (@owocki) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

@thelostone-mc
Copy link
Member

@mbeacom / @jasonrhaas the bot seems to flooding with pings upon being claimed!
I'm aware we've enabled multiple submissions -> but sort of is making it messy

It says @KennethAshley claimed it thrice. Am I missing something here ?

@mbeacom
Copy link
Contributor

mbeacom commented Feb 19, 2018

@thelostone-mc We're looking into this now. Seems to be a bug in the notification handling code. It should be updating existing comments for each unique action type (start work, submissions, etc).
Seems it's just creating new comments every time there is a bounty sync.

@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 21, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 21, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 21, 2018
@owocki
Copy link
Contributor Author

owocki commented Feb 21, 2018

sorry.. been traveling the last couple days... this is on my triage list

@owocki owocki mentioned this pull request Feb 21, 2018
10 tasks
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 22, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 22, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 22, 2018
@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 22, 2018
@owocki
Copy link
Contributor Author

owocki commented Feb 22, 2018

i just put in some fixes for the gitcoinbot duplicate comments.. will keep an eye on it from here on out. thanks for your patience yall

@owocki
Copy link
Contributor Author

owocki commented Feb 22, 2018

looking into gitcoinbot's comment here => #407 (comment)

@owocki
Copy link
Contributor Author

owocki commented Feb 22, 2018

just put in a fix ( 12c8837 ) . deleting the erroneous comment right now

@gitcoinco gitcoinco deleted a comment from gitcoinbot Feb 22, 2018
@KennethAshley
Copy link
Contributor

KennethAshley commented Feb 25, 2018

@owocki checkout my PR. There still might be some work to do on it but we wont be adding the alerts that were in the designs.

@owocki
Copy link
Contributor Author

owocki commented Feb 27, 2018

looking now

@owocki owocki closed this Mar 6, 2018
@owocki owocki removed the to do label Mar 6, 2018
@owocki owocki mentioned this pull request Mar 6, 2018
3 tasks
@owocki
Copy link
Contributor Author

owocki commented Mar 9, 2018

@gitcoinbot
Copy link
Member

The funding of 0.08 ETH (55.64 USD @ $695.55/ETH) attached to this issue has been approved & issued to @KennethAshley.

owocki added a commit that referenced this pull request Mar 9, 2018
@mbeacom mbeacom deleted the kevin/new_faucet_page branch April 16, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants