get Faucet Page across the finish line #407

Closed
wants to merge 25 commits into
from

Conversation

Projects
None yet
7 participants
@owocki
Member

owocki commented Feb 13, 2018

This is a continuation of #211 and #258 (thanks @usulix ) meant to deliver the scope for #184

TODOS

  • - Migrated to python3
  • - Cleanup design, Add design from #184
  • - Update the 'github profile' field to populate from the github login (top right).
  • - Test end to end

@owocki owocki added the in progress label Feb 13, 2018

owocki added some commits Feb 13, 2018

@owocki owocki changed the title from (WIP) new Faucet Page to (WIP) get new Faucet Page across the finish line Feb 13, 2018

This was referenced Feb 13, 2018

@owocki owocki changed the title from (WIP) get new Faucet Page across the finish line to get Faucet Page across the finish line Feb 13, 2018

@codecov

This comment has been minimized.

Show comment Hide comment
@codecov

codecov bot Feb 13, 2018

Codecov Report

Merging #407 into master will increase coverage by 0.37%.
The diff coverage is 43.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   28.35%   28.73%   +0.37%     
==========================================
  Files          87       90       +3     
  Lines        4151     4260     +109     
  Branches      498      505       +7     
==========================================
+ Hits         1177     1224      +47     
- Misses       2930     2992      +62     
  Partials       44       44
Impacted Files Coverage Δ
app/app/settings.py 89.79% <100%> (+0.21%) ⬆️
app/app/urls.py 100% <100%> (ø) ⬆️
app/faucet/views.py 25.33% <25.33%> (ø)
app/faucet/admin.py 73.33% <73.33%> (ø)
app/faucet/models.py 88.23% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822a274...b7f05bb. Read the comment docs.

codecov bot commented Feb 13, 2018

Codecov Report

Merging #407 into master will increase coverage by 0.37%.
The diff coverage is 43.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   28.35%   28.73%   +0.37%     
==========================================
  Files          87       90       +3     
  Lines        4151     4260     +109     
  Branches      498      505       +7     
==========================================
+ Hits         1177     1224      +47     
- Misses       2930     2992      +62     
  Partials       44       44
Impacted Files Coverage Δ
app/app/settings.py 89.79% <100%> (+0.21%) ⬆️
app/app/urls.py 100% <100%> (ø) ⬆️
app/faucet/views.py 25.33% <25.33%> (ø)
app/faucet/admin.py 73.33% <73.33%> (ø)
app/faucet/models.py 88.23% <88.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822a274...b7f05bb. Read the comment docs.

@owocki owocki added to do and removed in progress labels Feb 13, 2018

@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Feb 14, 2018

Member

This issue now has a funding of 0.08 ETH (73.47 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $8381.33 more Funded OSS Work Available at: https://gitcoin.co/explorer
Member

gitcoinbot commented Feb 14, 2018

This issue now has a funding of 0.08 ETH (73.47 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $8381.33 more Funded OSS Work Available at: https://gitcoin.co/explorer
@vs77bb

This comment has been minimized.

Show comment Hide comment
@vs77bb

vs77bb Feb 14, 2018

@owocki How is this one looking? Are you working it or is it open still?

vs77bb commented Feb 14, 2018

@owocki How is this one looking? Are you working it or is it open still?

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 14, 2018

Member

tis open

Member

owocki commented Feb 14, 2018

tis open

@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Feb 15, 2018

Member

Work has been started on the 0.08 ETH (73.48 USD) funding by:

  1. @KennethAshley

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

Member

gitcoinbot commented Feb 15, 2018

Work has been started on the 0.08 ETH (73.48 USD) funding by:

  1. @KennethAshley

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Feb 16, 2018

Member

This issue now has a funding of 0.08 ETH (74.21 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $13294.2 more Funded OSS Work Available at: https://gitcoin.co/explorer
Member

gitcoinbot commented Feb 16, 2018

This issue now has a funding of 0.08 ETH (74.21 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $13294.2 more Funded OSS Work Available at: https://gitcoin.co/explorer
@KennethAshley

This comment has been minimized.

Show comment Hide comment
@KennethAshley

KennethAshley Feb 16, 2018

Contributor

@owocki what is getting this across the line? Was the faucet ever successful?

Contributor

KennethAshley commented Feb 16, 2018

@owocki what is getting this across the line? Was the faucet ever successful?

@tanmayanand44

This comment has been minimized.

Show comment Hide comment
@tanmayanand44

tanmayanand44 Feb 17, 2018

@owocki Please guide a little.What to do here?

@owocki Please guide a little.What to do here?

@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Feb 17, 2018

Member

Work has been started on the 0.08 ETH (76.95 USD) funding by:

  1. @KennethAshley

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

Member

gitcoinbot commented Feb 17, 2018

Work has been started on the 0.08 ETH (76.95 USD) funding by:

  1. @KennethAshley

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

@KennethAshley KennethAshley referenced this pull request Feb 17, 2018

Closed

Update Faucet html and styles #457

2 of 3 tasks complete
@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Feb 17, 2018

Member

Work for 0.08 ETH (77.13 USD) has been submitted by:

  1. @KennethAshley

Submitters, please leave a comment to let the funder (@owocki) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

Member

gitcoinbot commented Feb 17, 2018

Work for 0.08 ETH (77.13 USD) has been submitted by:

  1. @KennethAshley

Submitters, please leave a comment to let the funder (@owocki) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

@thelostone-mc

This comment has been minimized.

Show comment Hide comment
@thelostone-mc

thelostone-mc Feb 19, 2018

Member

@mbeacom / @jasonrhaas the bot seems to flooding with pings upon being claimed!
I'm aware we've enabled multiple submissions -> but sort of is making it messy

It says @KennethAshley claimed it thrice. Am I missing something here ?

Member

thelostone-mc commented Feb 19, 2018

@mbeacom / @jasonrhaas the bot seems to flooding with pings upon being claimed!
I'm aware we've enabled multiple submissions -> but sort of is making it messy

It says @KennethAshley claimed it thrice. Am I missing something here ?

@mbeacom

This comment has been minimized.

Show comment Hide comment
@mbeacom

mbeacom Feb 19, 2018

Member

@thelostone-mc We're looking into this now. Seems to be a bug in the notification handling code. It should be updating existing comments for each unique action type (start work, submissions, etc).
Seems it's just creating new comments every time there is a bounty sync.

Member

mbeacom commented Feb 19, 2018

@thelostone-mc We're looking into this now. Seems to be a bug in the notification handling code. It should be updating existing comments for each unique action type (start work, submissions, etc).
Seems it's just creating new comments every time there is a bounty sync.

@owocki owocki deleted a comment from gitcoinbot Feb 21, 2018

@owocki owocki deleted a comment from gitcoinbot Feb 21, 2018

@owocki owocki deleted a comment from gitcoinbot Feb 21, 2018

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 21, 2018

Member

sorry.. been traveling the last couple days... this is on my triage list

Member

owocki commented Feb 21, 2018

sorry.. been traveling the last couple days... this is on my triage list

@owocki owocki referenced this pull request Feb 21, 2018

Closed

Integration branch triage issues #474

6 of 10 tasks complete

@owocki owocki deleted a comment from gitcoinbot Feb 22, 2018

@owocki owocki deleted a comment from gitcoinbot Feb 22, 2018

@owocki owocki deleted a comment from gitcoinbot Feb 22, 2018

@owocki owocki deleted a comment from gitcoinbot Feb 22, 2018

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 22, 2018

Member

i just put in some fixes for the gitcoinbot duplicate comments.. will keep an eye on it from here on out. thanks for your patience yall

Member

owocki commented Feb 22, 2018

i just put in some fixes for the gitcoinbot duplicate comments.. will keep an eye on it from here on out. thanks for your patience yall

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 22, 2018

Member

looking into gitcoinbot's comment here => #407 (comment)

Member

owocki commented Feb 22, 2018

looking into gitcoinbot's comment here => #407 (comment)

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 22, 2018

Member

just put in a fix ( 12c8837 ) . deleting the erroneous comment right now

Member

owocki commented Feb 22, 2018

just put in a fix ( 12c8837 ) . deleting the erroneous comment right now

@owocki owocki deleted a comment from gitcoinbot Feb 22, 2018

@KennethAshley

This comment has been minimized.

Show comment Hide comment
@KennethAshley

KennethAshley Feb 25, 2018

Contributor

@owocki checkout my PR. There still might be some work to do on it but we wont be adding the alerts that were in the designs.

Contributor

KennethAshley commented Feb 25, 2018

@owocki checkout my PR. There still might be some work to do on it but we wont be adding the alerts that were in the designs.

@owocki

This comment has been minimized.

Show comment Hide comment
@owocki

owocki Feb 27, 2018

Member

looking now

Member

owocki commented Feb 27, 2018

looking now

@owocki owocki closed this Mar 6, 2018

@owocki owocki removed the to do label Mar 6, 2018

@owocki owocki referenced this pull request Mar 6, 2018

Merged

WIP: Feature/faucet #541

0 of 3 tasks complete
@gitcoinbot

This comment has been minimized.

Show comment Hide comment
@gitcoinbot

gitcoinbot Mar 9, 2018

Member

The funding of 0.08 ETH (55.64 USD @ $695.55/ETH) attached to this issue has been approved & issued to @KennethAshley.

Member

gitcoinbot commented Mar 9, 2018

The funding of 0.08 ETH (55.64 USD @ $695.55/ETH) attached to this issue has been approved & issued to @KennethAshley.

owocki added a commit that referenced this pull request Mar 9, 2018

@mbeacom mbeacom deleted the kevin/new_faucet_page branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment