Feature/chat mentors #6963
Merged
Feature/chat mentors #6963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6963 +/- ##
==========================================
- Coverage 26.66% 26.15% -0.51%
==========================================
Files 294 296 +2
Lines 28118 29330 +1212
Branches 4135 4345 +210
==========================================
+ Hits 7498 7672 +174
- Misses 20349 21387 +1038
Partials 271 271
Continue to review full report at Codecov.
|
androolloyd
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
@androolloyd looks like there are some conflicts, can you fix and rebase? thanks! |
|
oh also please put against master |
octavioamu
suggested changes
Jul 2, 2020
fix for infinite scrolling on project directory
…ting the chat window
…termost webapp changes needed
… on the dom, and lazy load the sidebar/iframe, in conjunction with a new notification approach for the main app, doesn't use postMessage and uses the websocket to the chat instead
… new flow, e2e flow is in place
- sidebar is full width for mobile now, and has a header(needs styling) - login flow is improved for mobile apps.
… and content document of hte iframe through cross origin setup.
…djustments to what js is loaded, chat is now available everywhere
…rs including @sponsor handle posts
androolloyd
force-pushed
the
feature/chat-mentors
branch
from
69f696d
to
1cf752a
Compare
octavioamu
suggested changes
Jul 27, 2020
danlipert
suggested changes
Jul 28, 2020
|
what is the ticket associated with this? is this still an active PR? |
danlipert
suggested changes
Aug 3, 2020
danlipert
approved these changes
Aug 5, 2020
thelostone-mc
approved these changes
Aug 5, 2020
|
@octavioamu this look good to you? other than the conflicts? |
octavioamu
approved these changes
Aug 11, 2020
frankchen07
approved these changes
Aug 11, 2020
|
yayyyyy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chat has moved into a flyout sidebar.
Sponsors can now set chat mentors for their bounties through the hackathon integrated view.
Refers/Fixes
Testing