Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty: mobile alignment fix #762

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

Description

Fixed up the actions buttons to ensure it's rendered right on mobile

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
Testing

screen shot 2018-04-02 at 1 32 40 am

Fixes

@mkosowsk
Copy link

mkosowsk commented Apr 1, 2018

Hot damn, that turnaround time 😳LGTM 👍🏻

@thelostone-mc
Copy link
Member Author

@mkosowsk I was waiting for my subway delivery + netflix kept crashing. Hence :P

@codecov
Copy link

codecov bot commented Apr 1, 2018

Codecov Report

Merging #762 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   33.99%   33.95%   -0.04%     
==========================================
  Files         101      101              
  Lines        5775     5695      -80     
  Branches      672      666       -6     
==========================================
- Hits         1963     1934      -29     
+ Misses       3733     3685      -48     
+ Partials       79       76       -3
Impacted Files Coverage Δ
app/gitcoinbot/views.py 34.61% <0%> (-2.43%) ⬇️
app/tdi/views.py 18% <0%> (-1.08%) ⬇️
app/retail/views.py 41.02% <0%> (-1%) ⬇️
app/faucet/views.py 25.33% <0%> (-0.99%) ⬇️
app/marketing/mails.py 13.73% <0%> (-0.86%) ⬇️
app/external_bounties/views.py 17.82% <0%> (-0.81%) ⬇️
app/external_bounties/models.py 54.38% <0%> (-0.79%) ⬇️
app/marketing/views.py 10.46% <0%> (-0.38%) ⬇️
app/dashboard/views.py 17.31% <0%> (-0.34%) ⬇️
app/dashboard/helpers.py 29.58% <0%> (-0.16%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e767c...4ed307f. Read the comment docs.

@mbeacom mbeacom added frontend This needs frontend expertise. mobile labels Apr 2, 2018
@PixelantDesign
Copy link
Contributor

Submit work should be priority CTA right? Stop work would be a white button?

@thelostone-mc
Copy link
Member Author

@PixelantDesign This PR is just for the mobile fix
What you are looking for is here #768 ^_^

@thelostone-mc
Copy link
Member Author

@mbeacom resolved conflicts + fixed linting

@mbeacom mbeacom merged commit eba26e4 into gitcoinco:master Apr 6, 2018
@thelostone-mc thelostone-mc deleted the bounty branch April 7, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants