decreaseses the login from from 7s to 2.3s by making the sync_profile tasks happen on a delay #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## stable #7652 +/- ##
==========================================
- Coverage 25.75% 25.74% -0.01%
==========================================
Files 324 324
Lines 32420 32436 +16
Branches 4798 4799 +1
==========================================
+ Hits 8349 8352 +3
- Misses 23783 23791 +8
- Partials 288 293 +5
Continue to review full report at Codecov.
|
owocki
commented
Oct 11, 2020
| actually_sync_profile(handle, user=user, hide_profile=hide_profile) | ||
|
|
||
|
|
||
| def actually_sync_profile(handle, user=None, hide_profile=True): |
There was a problem hiding this comment.
many of the chat related tasks here could be done on a delay as well; a further PR would possibly do that so that upon first login were not blocking on things like chat tasks to create the profile
owocki
changed the title
thelostone-mc
approved these changes
Oct 12, 2020
|
getting this into master and then into stable for this weeks deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
decreaseses the login from from 7s to 2.3s by making the sync tasks happen on a delay
Refers/Fixes
self evident
Testing
tested locally