Fix button not disabled #7716
Merged
Fix button not disabled #7716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can now add disabled attr.
walidmujahid
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
@octavioamu my apologies for the delay. Here is the fix for #7290 (comment) |
octavioamu
approved these changes
Oct 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #7716 +/- ##
==========================================
+ Coverage 25.42% 25.44% +0.01%
==========================================
Files 328 328
Lines 33044 33044
Branches 4919 4919
==========================================
+ Hits 8401 8407 +6
+ Misses 24356 24350 -6
Partials 287 287
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the join buttons on hackathon onboard after after first click to prevent double clicking. On failure, button is renabled.
Refers/Fixes
fixes #7290 (comment)