Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bounty: process + kill bounty width fix #782

Merged
merged 2 commits into from
Apr 4, 2018
Merged

bounty: process + kill bounty width fix #782

merged 2 commits into from
Apr 4, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 4, 2018 •
edited
Loading

Description

screen shot 2018-04-04 at 7 41 02 am

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • html
Refers/Fixes

@thelostone-mc thelostone-mc mentioned this pull request Apr 4, 2018
Merged
3 tasks
@codecov
Copy link

codecov bot commented Apr 4, 2018 •
edited
Loading

Codecov Report

Merging #782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   33.87%   33.87%           
=======================================
  Files         101      101           
  Lines        5712     5712           
  Branches      669      669           
=======================================
  Hits         1935     1935           
  Misses       3698     3698           
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97557b...0bc2573. Read the comment docs.

@mkosowsk mkosowsk mentioned this pull request Apr 4, 2018
Closed
kziemianek
kziemianek reviewed Apr 4, 2018
View reviewed changes
Copy link
Contributor

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u fix #786 also ? :) seems to be related.

app/dashboard/templates/process_bounty.html
@@ -36,7 +36,7 @@
{% include 'shared/zero_balance_error.html' %}
{% include 'shared/unlock_metamask.html' %}
<div class="col offset-md-1 col-md-10 d-flex align-items-center justify-content-center" id="primary_form">
<div class="d-flex justify-content-center flex-column mt-5 w-50" id="primary_subform">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is similar problem in kill_bounty.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :P

@thelostone-mc thelostone-mc changed the title process_bounty: width fix bounty: process + kill bounty width fix Apr 4, 2018
@thelostone-mc
Copy link
Member Author

@mbeacom this is my new fav meme for small fixes

x

@owocki owocki merged commit ea871a3 into gitcoinco:master Apr 4, 2018
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH (19.2 USD @ $384.04/ETH) has been granted to @thelostone-mc for this issue from Kevin. ⚡️

The sender had the following public comments:

Its been great having you around to steward the repos :)

Nice work @thelostone-mc! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@thelostone-mc thelostone-mc deleted the bug branch April 4, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kziemianek kziemianek kziemianek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thelostone-mc @gitcoinbot @kziemianek @owocki