You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before the changes were made for SelectedFiles to return a blob path rather than full-path I've been making changes so I could concat/replace/etc these variables via "Run on PowerShell" option and one of the problems I ran into is that this kind of escaping did not work.
So I went to see how ProcessStartInfo does it and it was different than current method. When I changed current method to what's used in the BCL, then the test-cases for WSL and Windows became identical. Could you look at this commit to see what I mean: mdonatas@768ca88
Basically I think we can unify these two methods esp. given that current method did not work when running with PowerShell mode.
The version I made is based on my experiments on what actually executes, e.g. when passed as parameter to cmd /c. If the patch checks out in practice (i.e. Executing with System.Diagnostics.Process), then I have no nitpicks about the specifics of the escaped output.
Before the changes were made for
SelectedFiles
to return a blob path rather than full-path I've been making changes so I could concat/replace/etc these variables via "Run on PowerShell" option and one of the problems I ran into is that this kind of escaping did not work.So I went to see how
ProcessStartInfo
does it and it was different than current method. When I changed current method to what's used in the BCL, then the test-cases for WSL and Windows became identical. Could you look at this commit to see what I mean: mdonatas@768ca88Basically I think we can unify these two methods esp. given that current method did not work when running with PowerShell mode.
Originally posted by @mdonatas-trafi in #11795 (comment)
The text was updated successfully, but these errors were encountered: