Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NBug] Access to the path 'C:\Program Files (x86)\GitExtensions\Re... #6570

Closed
tincy1993 opened this issue May 15, 2019 · 3 comments · Fixed by #6586
Closed

[NBug] Access to the path 'C:\Program Files (x86)\GitExtensions\Re... #6570

tincy1993 opened this issue May 15, 2019 · 3 comments · Fixed by #6586
Assignees
Labels
📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity 💤 status: no recent activity The issue is stale

Comments

@tincy1993
Copy link

Current behaviour

Expected behaviour

Steps to reproduce

Error Details

System.UnauthorizedAccessException: Access to the path 'C:\Program Files (x86)\GitExtensions\Recent' is denied.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.Directory.InternalCreateDirectory(String fullPath, String path, Object dirSecurityObj, Boolean checkHost)
   at System.IO.Directory.InternalCreateDirectoryHelper(String path, Boolean checkHost)
   at GitUI.WindowsJumpListManager.AddToRecent(String workingDir)
   at GitUI.CommandsDialogs.FormBrowse.InternalInitialize(Boolean hard)
   at GitUI.CommandsDialogs.FormBrowse.RefreshRevisions()
   at GitUI.GitUIExtensions.<InvokeAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.ThreadHelper.<>c__DisplayClass13_0.<<FileAndForget>b__0>d.MoveNext()

Environment

  • Git Extensions 3.1.0.5877
  • Build bb1687f
  • Git 2.21.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3394.0
  • DPI 96dpi (no scaling)
@ghost
Copy link

ghost commented May 15, 2019

Not enough information. (See #6562 for comparison)

@RussKie
Copy link
Member

RussKie commented May 15, 2019

Are you running a portable version?

@ghost
Copy link

ghost commented May 16, 2019

@tincy1993 : Notice what vbjay said in #6571 (comment) :

We should not be writing to program files.... AT ALL. That is locked down by default. If you are running portable, do not place it in Program Files folder. Portable version needs to run in a writable folder. Non portable writes to User Profile folder.

RussKie added a commit to RussKie/gitextensions that referenced this issue May 16, 2019
It looks like there was a change in wording after git 2.16 that
changed from "fatal: Not a git..." to "fatal: not a git...".

The existing parser expected the warning to be in the lower case, and
thus failed for earlier versions of git.

The fix makes the check case insensitive.

Fixes gitextensions#6562
Closes gitextensions#6563
Closes gitextensions#6565
Closes gitextensions#6570
Closes gitextensions#6571
Closes gitextensions#6574
Closes gitextensions#6577
Closes gitextensions#6571
@ghost ghost assigned RussKie May 16, 2019
@ghost ghost added the status: ready label May 16, 2019
RussKie added a commit to RussKie/gitextensions that referenced this issue May 17, 2019
It looks like there was a change in wording after git 2.16 that
changed from "fatal: Not a git..." to "fatal: not a git...".

The existing parser expected the warning to be in the lower case, and
thus failed for earlier versions of git.

The fix makes the check case insensitive.

Fixes gitextensions#6562
Closes gitextensions#6563
Closes gitextensions#6565
Closes gitextensions#6570
Closes gitextensions#6571
Closes gitextensions#6574
Closes gitextensions#6577
Closes gitextensions#6571
@RussKie RussKie added 💤 status: no recent activity The issue is stale 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity and removed status: more info requested labels Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity 💤 status: no recent activity The issue is stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants