Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NBug] Remote URLs should appear in pairs. #6577

Closed
dnoakes opened this issue May 16, 2019 · 4 comments · Fixed by #6586
Closed

[NBug] Remote URLs should appear in pairs. #6577

dnoakes opened this issue May 16, 2019 · 4 comments · Fixed by #6586
Assignees
@RussKie

Comments

@dnoakes
Copy link

dnoakes commented May 16, 2019

Current behaviour

Expected behaviour

Steps to reproduce

Error Details

System.Exception: Remote URLs should appear in pairs.
   at GitCommands.GitModule.<GetRemotesAsync>g__ParseRemotes|155_0(IEnumerable`1 lines)
   at GitCommands.GitModule.<GetRemotesAsync>d__155.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.RemoteBranchTree.<LoadNodesAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.Tree.<ReloadNodesAsync>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.<>c__DisplayClass69_0.<<AddTree>b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.ThreadHelper.<>c__DisplayClass13_0.<<FileAndForget>b__0>d.MoveNext()

Environment

  • Git Extensions 3.1.0.5877
  • Build bb1687f
  • Git 2.16.2.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3394.0
  • DPI 192dpi (200% scaling)
RussKie added a commit to RussKie/gitextensions that referenced this issue May 16, 2019
@RussKie
fix: Throws on git remote call outside git repo
30d4f83 
It looks like there was a change in wording after git 2.16 that
changed from "fatal: Not a git..." to "fatal: not a git...".

The existing parser expected the warning to be in the lower case, and
thus failed for earlier versions of git.

The fix makes the check case insensitive.

Fixes gitextensions#6562
Closes gitextensions#6563
Closes gitextensions#6565
Closes gitextensions#6570
Closes gitextensions#6571
Closes gitextensions#6574
Closes gitextensions#6577
Closes gitextensions#6571
@RussKie RussKie mentioned this issue May 16, 2019
Merged
@ghost ghost assigned RussKie May 16, 2019
@ghost ghost added the status: ready label May 16, 2019
@dnoakes
Copy link
Author

dnoakes commented May 16, 2019 •
edited

Seeing the same on custom build, error report:

Current behaviour

Happening on app launch. If I just close the error popup everything continues to work as usual with no apparent problem

Expected behaviour

Steps to reproduce

Error Details

System.Exception: Remote URLs should appear in pairs.
   at GitCommands.GitModule.<GetRemotesAsync>g__ParseRemotes|155_0(IEnumerable`1 lines)
   at GitCommands.GitModule.<GetRemotesAsync>d__155.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.RemoteBranchTree.<LoadNodesAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.Tree.<ReloadNodesAsync>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.BranchTreePanel.RepoObjectsTree.<>c__DisplayClass69_0.<<AddTree>b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.ThreadHelper.<>c__DisplayClass13_0.<<FileAndForget>b__0>d.MoveNext()

Environment

  • Git Extensions 3.1.0.5898
  • Build 5967abb (Dirty)
  • Git 2.16.2.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3394.0
  • DPI 192dpi (200% scaling)

@RussKie
Copy link
Member

RussKie commented May 16, 2019

Please try this build https://ci.appveyor.com/api/buildjobs/yhoaokuijg0feqpa/artifacts/combined.3.1.0.5900-unsigned.zip

RussKie added a commit to RussKie/gitextensions that referenced this issue May 17, 2019
@RussKie
fix: Throws on git remote call outside git repo
e545266 
It looks like there was a change in wording after git 2.16 that
changed from "fatal: Not a git..." to "fatal: not a git...".

The existing parser expected the warning to be in the lower case, and
thus failed for earlier versions of git.

The fix makes the check case insensitive.

Fixes gitextensions#6562
Closes gitextensions#6563
Closes gitextensions#6565
Closes gitextensions#6570
Closes gitextensions#6571
Closes gitextensions#6574
Closes gitextensions#6577
Closes gitextensions#6571
@RussKie RussKie mentioned this issue May 17, 2019
Merged
@techi602 techi602 mentioned this issue May 17, 2019
Closed
@ghost
Copy link

ghost commented May 17, 2019

Possible duplicate of #6562

@gerhardol
Copy link
Member

gerhardol commented May 17, 2019 •
edited

Duplicate of #6562
Update Git (2.20 or later recommended) or try the portable build:
https://ci.appveyor.com/project/gitextensions/gitextensions/builds/24611218/artifacts

@duplicates-detector-bot duplicates-detector-bot bot mentioned this issue May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussKie RussKie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Throws on git remote call outside git repo RussKie/gitextensions
3 participants
@RussKie @dnoakes @gerhardol