fix: Throws on git remote call outside git repo
#6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like there was a change in wording after git 2.16 that changed from "fatal: Not a git..." to "fatal: not a git...". The existing parser expected the warning to be in the lower case, and thus failed for earlier versions of git. The fix makes the check case insensitive. Fixes gitextensions#6562 Closes gitextensions#6563 Closes gitextensions#6565 Closes gitextensions#6570 Closes gitextensions#6571 Closes gitextensions#6574 Closes gitextensions#6577 Closes gitextensions#6571
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #6586 +/- ##
==========================================
+ Coverage 47.09% 47.18% +0.08%
==========================================
Files 698 698
Lines 52622 52639 +17
Branches 6906 6907 +1
==========================================
+ Hits 24783 24838 +55
+ Misses 26517 26460 -57
- Partials 1322 1341 +19
|
gerhardol
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was a change in wording after git 2.16 that changed from "fatal: Not a git..." to "fatal: not a git...".
The existing parser expected the warning to be in the lower case, and thus failed for earlier versions of git.
Fixes #6562
Closes #6563
Closes #6565
Closes #6570
Closes #6571
Closes #6574
Closes #6577
Closes #6571
Proposed changes
Test methodology
Test environment(s)
✒️ I contribute this code under The Developer Certificate of Origin.