UI tweaks for v3 #5087

Allows form state (eg. maximised) to be restored, even if the saved window position does not exist on any current windows. Uses DpiUtil rather than font sizes to update splitter positions. Stores DPI value along with splitter position for correct scaling when running at a different DPI later.

Names were being split on spaces, meaning first, last and middle names would appear separately.

Some refactoring too.

The usage of RefFilterOptions does not map 1:1 with arguments.

Validation needs to ensure there are 41 bytes, not 21. This change uses a constant to make this more explicit.

Previously a List<ObjectId> with capacity 1 was added to. Actually it's cheap to count the number of parents. With that info, we can size the collection perfectly before parsing. We can also use an array instead of List<T>.

@pmiossec

Thanks to @pmiossec gitextensions#5087 (comment)

Removes the optional argument as it made no difference to any callers. It is safe to expect a list of names to not contain any blanks. Also use IReadOnlyList for the return type.

Previous code would compute statistics twice for no reason.

I saw a regeneration of the designer file which contained scaled values. This is potentially dangerous as the values would then be scaled again at a later point.

Implements gitextensions#4281 Show changed/new/deleted files and changed submodules

The call to UpdateGraph was holding a lock on _graphModel which blocked the UI thread from making progress.

Have seen commits with leading whitespace that cause indentation in the column.

This handles null and makes the culture explicit.

Convert from parial class to singular. Remove unused destructor. Seal class.

Each bool was 4 bytes. This should save 40 bytes per instance.

These types both referenced each other, and duplicated several members by delegating to the other. Merging them allows further clean ups.

This submodule is cloned from the gitextensions team. It includes a fix so that scroll bars are only displayed when there is actually something to scroll.

Uses the X form of the icon throughout. Optimised logo images are now in the "./Logo" folder. Original artwork is in the "./Logo/Artwork" folder.

Also add a VCX file for future edits via Gimp.

This co-opts the 'translate' step as a general post initialize step. It will translate text, and apply DPI scaling, in a single call. A side effect of this change is that all forms must now apply DPI scaling. If they don't they'll see runtime exceptions on load.

Only Yes is evaluated. It makes no difference if you select No or Cancel.

Removes reference to 'abort' as no matter what you select the action will be aborted. It is not part of the user's decision.

The setter is needed for use via reflection.

Only if the scaled image would still fit in the viewable area.

Apparently the only way to do this is via the image list. We increase the height of the icons which adds a bit of space between rows in the tree.

Remove unused images. Consistent naming. Add new icon images.

Previously if you visited a text file, then an image, then another text file, you would briefly see the the first file's text before the third's completed loading. This change clears the text out when an image is set.

Previously unavailable items were left in the context menu in a disabled state. This practice is common from main menu items, but not for context menus. This commit means the user doesn't see non-contextual menu items in a context menu.

The exception could be seen when pressing Ctrl+L then Ctrl+R elsewhere in the revision grid.

Avoid image alpha blending issue of native painting.

This bug caused no entries to appear in the FileStatusList when that setting was selected.

These are used by ReSharper's spell checker.

Extract common code from GitExtensionsForm into new class GitExtensionsControlInitialiser.

This is quite an extensive set of changes, done with the help of ReSharper's upcoming spell checker, now in early access.

Make most GitSubmoduleStatus properties readonly. Add IGitRef.ObjectId.

Relates to gitextensions#5162

This change makes it delete expired and corrupt avatar images from the file system. Without this change, corrupt files that fail to download will cause exceptions during loading/rendering/scrolling which can introduce jitter in the UI.

The observable is scheduled by the consumer anyway, so it makes no difference which thread calls subject.OnCompleted().

A brief skim through the GitExtensions repo history for email addresses ending with "@users.noreply.github.com" shows the following: * 25421792+mserfli * 33052757+freza-tm * gpongelli * odie2 * palver123 * RaMMicHaeL * SamuelLongchamps We correctly handle the format *without* the numbers. This change adds support for email prefixes that include the number, and strip the number off before using the GitHub API for the actual Gravatar URL.

This makes the application feel more responsive by showing the loading screen immediately.

This animates a rotating series of dots spaced evenly around an outer circle. It renders smoothly on high DPI displays, unlike the GIF. The 2.5kB animated GIF file used previously has been removed.

The prune operation would have no effect as the Clear call on line 725 clears everything else out anyway. Extend Clear to cover additional internal collections, previously covered by Prune which no longer occurs.

One step towards making RevisionReader stateless so that we can re-use a single instance of it in RevisionGridControl.

Makes RevisionReader stateless so that we can re-use a single instance of it in RevisionGridControl.

State is a very general term. This makes it more clear what the state relates to.

graphModel.GetLaneRow(index) is more clear than graphModel[index] for someone new to the code.

If a revision has been marked good/bad in a bisect, it will be rendered with an icon in the revision grid's message column.

Introduce GitRefType enum and flatten multiple bool properties.

Previously, changing the location of the commit info panel would result in the order changing when moving the commit info back to the lower tab control. This commit also moves the diff tab alongside the commit info tab, before the file tree tab.

ICSharpCode.TextEditor.dll used to be in Git under the Bin folder. Nowadays it's taken from a submodule and is copied into the output folder at build time. We must copy it from there.

Use local functions. Seal class. Rename some methods. Make field readonly.

Path.GetTempFileName actually creates a file on disk. Old code only used the name of that file to create a different file with ".cmd" extension. It would never delete the original file. This change only creates one temporary file, and ensures is is deleted, even in case of an exception. The temporary file has form "GitExtensions-0a98b7908798e79d8f7e.cmd" to identify its source in the temp folder.

Avoids allocating a single string with all log entries.

Apply same ordering to refs in tool tip as well.

Applies to the diff views throughout the application. Relates to gitextensions#4619 Outstanding controls are the repo object tree and the file status list. There may be others.

Dumps first 4kB as a hex/ASCII dump.

Disable folding line in UI. We never use it, and it looks noisy. Override the default line number styling.

Implementation was broken, and hardly anything used it. Users who specified alphabetical order now do their own ordering.

.NET 3.5 is no longer in the picture

When debugging in VS we'd regularly see IOE when closing forms. Continuing worked without trouble. Some other work I did started to expose issues with the CommitInfo panel and its expectations about command sources. This commit: - Makes GitModuleControl.Module null if the source is not initialised - Doesn't set the source to null when disposed, preventing reinit - Reloads commit info when the source becomes available - Improves API documentation

This icon appears in the commit message column, immediately before any "fixup!" or "squash!" prefix on messages. The icon brings attention to such commits so that the author may be reminded to interactively rebase prior to pushing.

Initially I tried extending it for the whole Load method, but testing never showed a change to the cursor on screen.

- Introduced type `Remote` which clashed with a namespace - Renamed the namespace from `Remote` to `Remotes` - Renamed `GitModule.GetRemotes` to `GitModule.GetRemoteNames` - Added `GitModule.GetRemotes` which returns `IROL<Remote>` - Remote object has fetch/push URL(s)

This method is called within `InitializeCompleted`, and needn't be called again here.

Reduce allocations during commit reads by avoiding event args.

This fixes several plugin forms having the default WinForms icon.

% Conflicts: % GitExtUtils/GitUI/TaskExtensions.cs % GitUI/UserControls/FileStatusList.cs % GitUI/UserControls/RevisionGrid.cs % GitUI/UserControls/RevisionGrid/GitRefListsForRevision.cs % GitUI/UserControls/RevisionGridClasses/CopyContextMenuViewModel.cs % UnitTests/GitUITests/GitUITests.csproj

Prior code was failing when the selected commit from the first repo was not found in the second.

- Multiple consecutive separators for artificial commits - 'Checkout branch' and 'merge into current branch' submenus missing Bug was related to the recent change that hid disabled menu items. After setting and item's `Visible` property to true, it still reads false, presumably because the menu is not yet on screen.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI tweaks for v3 #5087

UI tweaks for v3 #5087

Commits on Jul 18, 2018

Commits on Jul 22, 2018

Commits on Jul 23, 2018