Adjust the Azure Pipeline badge in our README #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the six months of development of the Azure Pipelines support, the patches went through quite a few iterations of changes, and to test those iterations, a temporary build definition was used. In the meantime, Azure Pipelines support made it to `master`, and we now have a regular Azure Pipeline, installed via the common GitHub App workflow. This new pipeline has a different name (git.git instead of test-git.git), and a new ID (11 instead of 2). Let's adjust the badge in our README to reflect that final shape of the Azure Pipeline. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/submit |
|
Submitted as pull.128.git.gitgitgadget@gmail.com |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| [](https://dev.azure.com/git/git/_build/latest?definitionId=2) | |||
There was a problem hiding this comment.
On the Git mailing list, Junio C Hamano wrote (reply to this):
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> During the six months of development of the Azure Pipelines support, the
> patches went through quite a few iterations of changes, and to test
> those iterations, a temporary build definition was used.
>
> In the meantime, Azure Pipelines support made it to `master`, and we now
> have a regular Azure Pipeline, installed via the common GitHub App
> workflow. This new pipeline has a different name (git.git instead of
> test-git.git), and a new ID (11 instead of 2).
>
> Let's adjust the badge in our README to reflect that final shape of the
> Azure Pipeline.
Always happy to see declaration of victory ;-).
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> README.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index 764c480c66..88f126184c 100644
> --- a/README.md
> +++ b/README.md
> @@ -1,4 +1,4 @@
> -[](https://dev.azure.com/git/git/_build/latest?definitionId=2)
> +[](https://dev.azure.com/git/git/_build/latest?definitionId=11)
>
> Git - fast, scalable, distributed revision control system
> =========================================================
There was a problem hiding this comment.
On the Git mailing list, Johannes Schindelin wrote (reply to this):
Hi Junio,
On Sat, 23 Feb 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > During the six months of development of the Azure Pipelines support, the
> > patches went through quite a few iterations of changes, and to test
> > those iterations, a temporary build definition was used.
> >
> > In the meantime, Azure Pipelines support made it to `master`, and we now
> > have a regular Azure Pipeline, installed via the common GitHub App
> > workflow. This new pipeline has a different name (git.git instead of
> > test-git.git), and a new ID (11 instead of 2).
> >
> > Let's adjust the badge in our README to reflect that final shape of the
> > Azure Pipeline.
>
> Always happy to see declaration of victory ;-).
Yep! I did take an internal victory lap, too.
Thank you for your help and your patience on this issue!
Ciao,
Dscho
>
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > README.md | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.md b/README.md
> > index 764c480c66..88f126184c 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -1,4 +1,4 @@
> > -[](https://dev.azure.com/git/git/_build/latest?definitionId=2)
> > +[](https://dev.azure.com/git/git/_build/latest?definitionId=11)
> >
> > Git - fast, scalable, distributed revision control system
> > =========================================================
>
|
This branch is now known as |
|
This patch series was integrated into pu via git@39ffebd. |
|
This patch series was integrated into next via git@efd1d6c. |
Nice one... ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have an official Azure Pipeline (not the temporary, for-testing one I used during development), thanks to Peff! Let's link to it, too.