Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the Azure Pipeline badge in our README #128

Closed
wants to merge 1 commit into from
Closed

Adjust the Azure Pipeline badge in our README #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
@@ -1,4 +1,4 @@
[![Build Status](https://dev.azure.com/git/git/_apis/build/status/test-git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=2)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> During the six months of development of the Azure Pipelines support, the
> patches went through quite a few iterations of changes, and to test
> those iterations, a temporary build definition was used.
>
> In the meantime, Azure Pipelines support made it to `master`, and we now
> have a regular Azure Pipeline, installed via the common GitHub App
> workflow. This new pipeline has a different name (git.git instead of
> test-git.git), and a new ID (11 instead of 2).
>
> Let's adjust the badge in our README to reflect that final shape of the
> Azure Pipeline.

Always happy to see declaration of victory ;-).

>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index 764c480c66..88f126184c 100644
> --- a/README.md
> +++ b/README.md
> @@ -1,4 +1,4 @@
> -[![Build Status](https://dev.azure.com/git/git/_apis/build/status/test-git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=2)
> +[![Build Status](https://dev.azure.com/git/git/_apis/build/status/git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=11)
>  
>  Git - fast, scalable, distributed revision control system
>  =========================================================

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Junio,

On Sat, 23 Feb 2019, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > During the six months of development of the Azure Pipelines support, the
> > patches went through quite a few iterations of changes, and to test
> > those iterations, a temporary build definition was used.
> >
> > In the meantime, Azure Pipelines support made it to `master`, and we now
> > have a regular Azure Pipeline, installed via the common GitHub App
> > workflow. This new pipeline has a different name (git.git instead of
> > test-git.git), and a new ID (11 instead of 2).
> >
> > Let's adjust the badge in our README to reflect that final shape of the
> > Azure Pipeline.
> 
> Always happy to see declaration of victory ;-).

Yep! I did take an internal victory lap, too.

Thank you for your help and your patience on this issue!

Ciao,
Dscho

> 
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  README.md | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.md b/README.md
> > index 764c480c66..88f126184c 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -1,4 +1,4 @@
> > -[![Build Status](https://dev.azure.com/git/git/_apis/build/status/test-git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=2)
> > +[![Build Status](https://dev.azure.com/git/git/_apis/build/status/git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=11)
> >  
> >  Git - fast, scalable, distributed revision control system
> >  =========================================================
>

[![Build Status](https://dev.azure.com/git/git/_apis/build/status/git.git)](https://dev.azure.com/git/git/_build/latest?definitionId=11)

Git - fast, scalable, distributed revision control system
=========================================================
Expand Down