-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outreachy] bisect: allow git bisect
to run from subdirectory
#765
base: master
Are you sure you want to change the base?
Conversation
git bisect
to run from subdirectorygit bisect
to run from subdirectory
A couple of suggestions:
The test could be really basic, like test_expect_success 'runs in a subdirectory' '
mkdir -p subdir &&
git -C subdir bisect start &&
git -C subdir bisect good &&
git -C subdir bisect reset
' |
As `git rebase` was never prevented to run from subdirectory we shouldn't prevent `git bisect` to run from subdirectories. This commit removes the restriction on git bisect to run only from top level directory thereby allowing it to run from any subdirectory. Signed-off-by: Sangeeta Jain <sangunb09@gmail.com>
Thanks for the suggestions @dscho. Also should I add [Outreachy] in the commit message itself to ensure that it should be send as a subject in the patch? I was wondering if it's a good practice to add that in commit? |
I don't think that it should be part of the commit message... |
/preview |
Preview email sent as pull.765.git.1603270059099.gitgitgadget@gmail.com |
/submit |
Submitted as pull.765.git.1603271344522.gitgitgadget@gmail.com To fetch this version into
To fetch this version to local tag
|
On the Git mailing list, Phillip Wood wrote (reply to this):
|
User |
On the Git mailing list, Taylor Blau wrote (reply to this):
|
User |
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
User |
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
On the Git mailing list, Phillip Wood wrote (reply to this):
|
On the Git mailing list, Phillip Wood wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Sangeeta NB wrote (reply to this):
|
User |
On the Git mailing list, Phillip Wood wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
On the Git mailing list, Johannes Schindelin wrote (reply to this):
|
As
git rebase
was never prevented to run from subdirectory we shouldn'tprevent
git bisect
to run from subdirectories. This commit removes therestriction on git bisect to run only from top level directory thereby
allowing it to run from any subdirectory.
Signed-off-by: Sangeeta Jain sangunb09@gmail.com
cc: Johannes Schindelin johannes.schindelin@gmx.de
cc: Phillip Wood phillip.wood123@gmail.com
cc: Taylor Blau me@ttaylorr.com
cc: Johannes Schindelin Johannes.Schindelin@gmx.de
cc: Sangeeta NB sangunb09@gmail.com