Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexes should have higher priority on code #12

Closed
luizperes opened this issue Jun 13, 2017 · 1 comment
Closed

Regexes should have higher priority on code #12

luizperes opened this issue Jun 13, 2017 · 1 comment

Comments

@luizperes
Copy link
Member

Regexes should have priority over strings, ids, numbers and operators because it will define custom rules to the parser.

At the moment, it has one of the lowest parser priorities. https://github.com/github-aux/linguist-unknown/blob/chrome/src/scripts/ling-highlighter.js#L298

@luizperes luizperes self-assigned this Jun 13, 2017
@luizperes luizperes changed the title Regexes should have priority on code Regexes should have higher priority on code Jun 13, 2017
@luizperes
Copy link
Member Author

Regexes will have lowest priority in the code, once that would cost a lot of speed for the parser because of the match, therefore we won't implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant