Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Racket color based on new logo #3815

Closed
wants to merge 7 commits into from
Closed

Update Racket color based on new logo #3815

wants to merge 7 commits into from

Conversation

pmaddams
Copy link
Contributor

@pmaddams pmaddams commented Sep 8, 2017

No description provided.

Some time ago, the Racket folks updated their logo as part of the rebranding from PLT Scheme. You can see the new logo here: https://github.com/racket/icons/blob/master/racket-logo.svg.

Racket is a great language and deserves a cool GitHub color to match their logo. Also, Haskell's color was recently changed from green to purple: #3728. We don't want people to think Haskell is the only functional programming game in town.
@lildude
Copy link
Member

lildude commented Sep 13, 2017

Unfortunately this PR can't be merged yet as it's not passing CI because the colour you've chosen is too similar to that used by another language. You're going to need to experiment with the colour until you find one that didn't conflict. I understand this may be quite a challenge.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to change the threshold, please do some thorough tests and justify why this is needed.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also gonna have to stop you now. Increasing the threshold to satisfy your colour selection is not the best approach (it's also the wrong way round) as you can see from the ever increasing number of conflicts being reported in the subsequent tests.

Take a look at the colours reported in the initial failure:

#3e5ba9 (your chosen colour)
#375eab
#4F5D95
#3e5ba9

As you can see, they're all very very close and not easily distinguishable.

You need to adjust your chosen colour, not the threshold.

@pmaddams pmaddams closed this Sep 13, 2017
@pmaddams pmaddams reopened this Sep 13, 2017
@lildude
Copy link
Member

lildude commented Sep 13, 2017

Apologies for the failed commits. Because I don't have a development machine right now, I am making changes on my phone. Several points:

No problems, though you'll find it much easier to test this stuff on an actual computer 😉

The chosen color is the same one used in Racket's logo. If you look at the raw SVG file you will see:
<path id="blue-piece" fill="#3E5BA9" ...

I saw that.

I understand the color is somewhat similar to Go and PHP. However, they are clearly not identical, and blue is a very popular color. There is little danger that someone will confuse Racket with Go or Racket with PHP.

Indeed. Blue is incredibly popular and it is for this reason we've had to implement this threshold test and it's why, if you're going to want a shade of blue, you're going to have to pick another.

#3e5ba9 (your chosen colour) and #4F5D95 are so remarkably close that it's almost impossible to tell the two apart when they're side-by-side as they could be in the language statistics bar (I know, highly unlikely, but remotely possible):

option1

#3e5ba9 (your chosen colour) and #375eab are a little more distinguishable, but not easily:

option2

(I cunningly changed the proportions between the two screenshots to make guessing the breakpoint harder 😉)

Why not keep the current colour #22228f? It's not that far off the colour you're trying to set it to
and many other languages stick with their original choice so as not to confuse their users.

Or how about a variant of the red (#9F1D20)? This currently conflicts with only one other language so a slight tweak to the hue or something should get past this. A quick little testing shows #9F1D26 is close enough to the red in the logo to be almost indistinguishable and without any conflicts. You could try a similar tweak with your blue if you absolutely want a blue, though this will much more of a laborious task due to the high number of blues already in use.

The threshold should be decreased anyway because with an increasing number of languages on GitHub, conflicts are bound to occur. It is like filling up a hash table; you must expect collisions. Having done a search of the possible values, 0.01 is the only one that works without going to a higher number of decimal places.

Indeed there are an increasing number of languages and conflicts do occur, however we (the Linguist community) can't unilaterally decide on lowering the threshold without a full and comprehensive analysis of the languages on GitHub and how such a change would impact the overall appearance of the language statistics bar on GitHub.com, especially when there are a lot of unused, and significantly more unique, colours still available.

Not every language has a colour directly associated with their logo or website colours as a deliberate choice to make it more unique on GitHub, that's also an option.

@pmaddams pmaddams closed this Sep 13, 2017
lildude pushed a commit that referenced this pull request Mar 1, 2019
In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from `#22228f` to `#3c5caa`.

This won't turn out like the #4319 (Rust) debacle for the following reasons:
- The blue color is official, not just a random opinion.
- We are going from a dark and not easily visible shade of blue to a lighter shade of the same color.
- Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis.

Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants