Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting #3815 (Update Racket color) #4415

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Revisiting #3815 (Update Racket color) #4415

merged 1 commit into from
Mar 1, 2019

Conversation

pmaddams
Copy link
Contributor

@pmaddams pmaddams commented Feb 11, 2019

In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from #22228f to #3c5caa.

This won't turn out like the #4319 (Rust) debacle for the following reasons:

  • The blue color is official, not just a random opinion.
  • We are going from a dark and not easily visible shade of blue to a lighter shade of the same color.
  • Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis.

Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.

In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from `#22228f` to `#3c5caa`.

This won't turn out like the #4319 (Rust) debacle for the following reasons:
- The blue color is official, not just a random opinion.
- We are going from a dark and not easily visible shade of blue to a lighter shade of the same color.
- Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis.

Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.
@pchaigno
Copy link
Contributor

Anywhere we could address the Racket community at large to get their opinion (e.g., mailing list)?

@pmaddams
Copy link
Contributor Author

Yes, that's a good idea. I've mailed the users list: https://groups.google.com/forum/#!topic/racket-users/suv7Kv7qUBw

@pmaddams
Copy link
Contributor Author

I haven't heard any objections after one week. One of the core Racket developers responded "that sounds great". I think it is safe to continue.

@lildude
Copy link
Member

lildude commented Mar 1, 2019

From an email sent directly to me 😢 :

Is there a reason the changes have not been merged?

Because I've not had the time to do it :-D - Linguist is very low on my list of priorities. And when I approve and merge a PR isn't really much of an issue as changes won't appear on GitHub until such time as I make a release, which in itself needs waaay more time than you'd think.

As an aside, it's not particularly nice emailing maintainers directly asking about an issue when you could have simply commented on the issue.

@lildude lildude merged commit 733cfff into github-linguist:master Mar 1, 2019
@pmaddams
Copy link
Contributor Author

pmaddams commented Mar 1, 2019

Sorry about that. Thanks Colin.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants