Revise pattern to fix Coq/Verilog misclassification

[yumaueda]

#4750

Revise some patterns for avoiding Coq/Verilog misdetection.

Description

https://github.com/github/linguist/blob/643c091e8d1e8c20401d1267ca558d304ebae8ca/lib/linguist/heuristics.yml#L462-L463

The first pattern for Coq could also match Verilog synthesis attribute; then I revised patters for Coq and Verilog.

Checklist:

• I am fixing a misclassified language
  • I have included a new sample for the misclassified language:
    • Sample source(s): samples/Verilog/ram.v
    • Sample license(s): MIT
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

[pchaigno]

Thanks for the improvement @0x00a1e9!

Could you add a sample file to demonstrate this? One that used to be incorrectly detected as Coq. Your own files might do the trick if you can (re)license them under a permissive license (e.g., MIT).

/cc @medvednikov who helped design these heuristic rules in #4564.

[yumaueda]

I added a sample Verilog file used to be misclassified as Coq under the MIT license.

[pchaigno]

That Verilog sample files looks fairly different from those we already have (and as a result, the syntax highlighting doesn't work very well on that one). Any idea why that is? Is that a different dialect? In particular, the comments are different and they're the reason why the heuristic was failing.

[yumaueda]

In particular, the comments are different and they're the reason why the heuristic was failing.

I only use comment syntax defined in IEEE Std 1364-2005. What did you mention to by "comments"? Seems there's only one comment part in the sample...

[pchaigno]

What did you mention to by "comments"? Seems there's only one comment part in the sample...

That's the one I was referring to.

I'd really like to have @0x00a1e9 or @S-YOU's eyes on this.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.