Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why karma-phantomjs-launcher is in the "dependencies" ? #258

Closed
phodal opened this issue Nov 18, 2015 · 3 comments
Closed

Why karma-phantomjs-launcher is in the "dependencies" ? #258

phodal opened this issue Nov 18, 2015 · 3 comments
Labels
Milestone

Comments

@phodal
Copy link

phodal commented Nov 18, 2015

Currently, I work on a side project with Atom Electron, and I use this libs to access GitHub API.

But when I package the application, I found the size added more than 40M. Finally, and I found the karma-phantomjs-launcher is the reason, I think it should be in "devDependencies".

@aendra-rininsland
Copy link
Member

Yikes, really? When'd that happen? Will push a fix to that momentarily, thanks for letting us know!

@aendra-rininsland aendra-rininsland modified the milestones: v0.10.8, v0.10.7 Nov 18, 2015
@phodal
Copy link
Author

phodal commented Nov 18, 2015

@Aendrew Thanks for your quick fix.

When use the Electron to package the application, it will also package the node_modules. In the prev verison, the libs karma, phantomjs was depended by karma-phantomjs-launcher, those packages will also be package to application. the size of karma almost 30M, and phantomjs will be 15M.

@aendra-rininsland
Copy link
Member

@phodal Yep, is definitely a problem. Would also be problematic for Browserify and Webpack users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants