Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support endpoints that return objects in _requestAllPages #267

Closed
jeffstieler opened this issue Dec 29, 2015 · 0 comments
Closed

Support endpoints that return objects in _requestAllPages #267

jeffstieler opened this issue Dec 29, 2015 · 0 comments

Comments

@jeffstieler
Copy link
Contributor

Currently, if you call _requestAllPages on an endpoint that returns an object, like /search/, you won't get any results back.

This is due to the handling of the result object - it's assumed it will be an array.

See: https://github.com/michael/github/blob/master/github.js#L124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffstieler