Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goroutine path output may contain duplicates #65

Closed
kalexmills opened this issue Dec 23, 2020 · 2 comments · Fixed by #68
Closed

Goroutine path output may contain duplicates #65

kalexmills opened this issue Dec 23, 2020 · 2 comments · Fixed by #68
Labels
bug Something isn't working

Comments

@kalexmills
Copy link
Contributor

The paths output in github-vet/rangeloop-pointer-findings#6717 appear to contain duplicates. We might expect to see this in case the callgraph ends up with multiple non-unique nodes that have the same signature. Based on my recollection of the type definition, that's not impossible.
@kalexmills kalexmills added the bug Something isn't working label Dec 23, 2020
@kalexmills
Copy link
Contributor Author

I'm including a hack that will at least silence duplicate output.

Still not sure of the actual root-cause. I plan to write some graph-theory unit tests for the callgraph to surface any issues there.

@kalexmills
Copy link
Contributor Author

Checked back through the BFS and reminded myself we want all our BFS implementations to visit every edge of the graph -- not just reach every node of the graph.

I'm happier now.

This was referenced Dec 23, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX | Add tests for callgraph github-vet/bots
1 participant
@kalexmills