se0g1/cve-2018-1002101: test/e2e/framework/util.go; 25 LoC

[githubvet]

Found a possible issue in se0g1/cve-2018-1002101 at test/e2e/framework/util.go

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

Click here to see the code in its original context.

Click here to show the 25 line(s) of Go which triggered the analyzer.

for _, pod := range podList.Items {
	if len(ignoreLabels) != 0 && ignoreSelector.Matches(labels.Set(pod.Labels)) {
		continue
	}
	res, err := testutils.PodRunningReady(&pod)
	switch {
	case res && err == nil:
		nOk++
	case pod.Status.Phase == v1.PodSucceeded:
		Logf("The status of Pod %s is Succeeded which is unexpected", pod.ObjectMeta.Name)
		badPods = append(badPods, pod)
		// it doesn't make sense to wait for this pod
		return false, errors.New("unexpected Succeeded pod state")
	case pod.Status.Phase != v1.PodFailed:
		Logf("The status of Pod %s is %s (Ready = false), waiting for it to be either Running (with Ready = true) or Failed", pod.ObjectMeta.Name, pod.Status.Phase)
		notReady++
		badPods = append(badPods, pod)
	default:
		if metav1.GetControllerOf(&pod) == nil {
			Logf("Pod %s is Failed, but it's not controlled by a controller", pod.ObjectMeta.Name)
			badPods = append(badPods, pod)
		}
		//ignore failed pods that are controlled by some controller
	}
}

Click here to show extra information the analyzer produced.

No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {GetControllerOf 1} was not found in the callgraph; reference was passed directly to third-party code

Leave a reaction on this issue to contribute to the project by classifying this instance as a Bug 👎, Mitigated 👍, or Desirable Behavior 🚀
See the descriptions of the classifications here for more information.

commit ID: 08eb5fb80339f2738e62ab25142bde16debd4a60