Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Release 2.4.2 "We Like Strings Too" #1475

Merged
merged 18 commits into from Feb 9, 2018
Merged

Release 2.4.2 "We Like Strings Too" #1475

merged 18 commits into from Feb 9, 2018

Commits on Feb 8, 2018

  1. Add metrics tests that validate all the data

    - Add test to validate that the UsageService writes all the data
    - Add test to validate that the MetricsService sends all the data
    - Move the usage tracker tests into a decent namespace and one single fixture
    shana committed Feb 8, 2018
    Copy the full SHA
    33e5edf View commit details
    Browse the repository at this point in the history
  2. Ooops typo

    shana committed Feb 8, 2018
    Copy the full SHA
    40b19cb View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    d28c864 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    67900f6 View commit details
    Browse the repository at this point in the history
  5. Fix metrics and tests for them

    shana committed Feb 8, 2018
    Copy the full SHA
    23cd870 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    72899c8 View commit details
    Browse the repository at this point in the history
  7. Missed an added file

    shana committed Feb 8, 2018
    Copy the full SHA
    2af1abf View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    a64321f View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    2380135 View commit details
    Browse the repository at this point in the history
  10. Fix names of tests

    shana committed Feb 8, 2018
    Copy the full SHA
    a5a1c50 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    ac66dec View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    e165776 View commit details
    Browse the repository at this point in the history
  13. Log errors

    shana committed Feb 8, 2018
    Copy the full SHA
    a8ac83a View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    542966a View commit details
    Browse the repository at this point in the history
  15. Merge pull request #1467 from github/fixes/1466-metrics-fields-missing

    Fix metrics, take 2135413
    shana committed Feb 8, 2018
    Copy the full SHA
    855a566 View commit details
    Browse the repository at this point in the history
  16. Merge pull request #1472 from github/fixes/log-at-correct-levels

    Log things at appropriate levels
    shana committed Feb 8, 2018
    Copy the full SHA
    b568332 View commit details
    Browse the repository at this point in the history
  17. Fix SimpleApiClient.IsEnterprise().

    Previous unless you had called `GetRepository` on a `SimpleApiClient` instance, `IsEnterprise()` simply returned `false` without checking. Make sure we actually perform the check.
    
    Fixes #1473
    grokys committed Feb 8, 2018
    Copy the full SHA
    3be40a0 View commit details
    Browse the repository at this point in the history
  18. Merge pull request #1476 from github/fixes/1473-enterprise-instance-n…

    …ot-detected
    
    Fix SimpleApiClient.IsEnterprise().
    shana committed Feb 8, 2018
    Copy the full SHA
    78ad9f4 View commit details
    Browse the repository at this point in the history