New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise instance not detected. #1473

Closed
grokys opened this Issue Feb 8, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@grokys
Contributor

grokys commented Feb 8, 2018

From @awbushnell in #1457:

@meaghanlewis I am now having problems with the GitHub extension from showing anything... On my local system, all I do is load Visual Studio 2017.. Open the project I am working on that is being version controlled via Git. The Visual Studio Team Explorer properly sees it as a Git repo and shows me branch etc. information, but when I switch to the GitHub view, it simply displays:

capture

Notice in the image, GitHub empty, yet team explorer is properly showing Repo info...

Even clicking get started, just brings me to the team explorer view and nothing updates/happens.

I should note that in this case, I am NOT in any worktree at all, this is our main repo...

what is the output of running git remote -vv in the repository?

it looks correct, we are on GitHub enterprise and it spits the following 2 lines out:

origin [correcthttpspathtoourenterpriserepo] (fetch)
origin [correcthttpspathtoourenterpriserepo] (push)
@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

@grokys One follow up question.. In team explorer, I signed out and am attempting to sign back in, thinking maybe that might wake things up, but when I go to sign in via GitHub Enterprise, it prompts me for the server and then when it validates it, it prompts for a "token" do you know where I get that information from? I am used to only having to provide my credentials for our server, never had to enter any token... so a little confused now.

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

@awbushnell do you think you could create a new issue for that too? It gets a bit hard to track things when there are multiple issues in a single GitHub issue.

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

@awbushnell I've been able to reproduce this here, we should have a fix shortly for this issue. Sorry about that.

@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

grokys added a commit that referenced this issue Feb 8, 2018

Fix SimpleApiClient.IsEnterprise().
Previous unless you had called `GetRepository` on a `SimpleApiClient` instance, `IsEnterprise()` simply returned `false` without checking. Make sure we actually perform the check.

Fixes #1473
@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

@awbushnell this should be fixed in release 2.4.2 which has just been released. Please let us know if you have any more problems.

@grokys grokys closed this Feb 8, 2018

@grokys grokys added this to Done in BUGS via automation Feb 8, 2018

@meaghanlewis meaghanlewis removed this from Done in BUGS Feb 8, 2018

@awbushnell

This comment has been minimized.

awbushnell commented Feb 8, 2018

@grokys Hmm, I just updated to the version and it still only prompts for token.... FYI

@grokys

This comment has been minimized.

Contributor

grokys commented Feb 8, 2018

Yes, this is the issue for the repository not being detected. #1474 is the issue for the login, this will be in the next release - we didn't have time to get both of them in unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment