Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Fix SimpleApiClient.IsEnterprise(). #1476

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

grokys
Copy link
Contributor

@grokys grokys commented Feb 8, 2018

Previous unless you had called GetRepository on a SimpleApiClient instance, IsEnterprise() simply returned false without checking. Make sure we actually perform the check.

Fixes #1473

Previous unless you had called `GetRepository` on a `SimpleApiClient` instance, `IsEnterprise()` simply returned `false` without checking. Make sure we actually perform the check.

Fixes #1473
Copy link
Contributor

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. To note,

if ((isDotCom || isEnterprise) && await IsValidRepository(client))
is the "real" culprit (IsEnterprise being called before GetRepository, but since IsEnterprise doesn't require the repository object to be filled, the order dependency is not needed. WikiProbe, however, does require the repository object to be filled out, so we should audit it to make sure the api is sane.

@shana shana merged commit 78ad9f4 into release/2.4.2 Feb 8, 2018
@shana shana deleted the fixes/1473-enterprise-instance-not-detected branch February 8, 2018 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants