This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Removed DefaultRepositoryName #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From `IRepositoryPublishViewModel`. Seems to not be needed and was causing #279. The default repository name was being placed directly into `RepositoryPublishControl.nameText` in the control which meant: - it was only written to `RepositoryName` when the user clicked on the `nameText` control - which meant that `RepositoryName` was up until that point null - which meant that the validation for it was failing - which meant the "Publish" button was disabled. This commit just sets the `RepositoryName` to the default in the VM ctor meaning that that name gets immediately validated. `DefaultRepositoryName` didn't seem to be used anywhere else, so I removed it. cc: @haacked for a sanity check because it looks like you wrote this. Fixes #279
|
Yup, this looks very sane! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
IRepositoryPublishViewModel. Seems to not be needed and was causing #279.The default repository name was being placed directly into
RepositoryPublishControl.nameTextin the control which meant:RepositoryNamewhen the user clicked on thenameTextcontrolRepositoryNamewas up until that point nullThis commit just sets the
RepositoryNameto the default in the VM ctor meaning that that name gets immediately validated.DefaultRepositoryNamedidn't seem to be used anywhere else, so I removed it.cc: @haacked for a sanity check because it looks like you wrote this.
Fixes #279