New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish button disabled until user clicks repository name #279

Closed
mponce1 opened this Issue May 3, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@mponce1
Contributor

mponce1 commented May 3, 2016

Steps to reproduce:
1. Create new local repository
2. Go to publish (double click repository, sync, publish to github)

screen shot 2016-05-02 at 4 54 14 pm

3. Click repository name field, then away from it (notice button is now enabled)

Expected result: Publish button available by default.
Actual result: Publish button is disabled until user clicks repository name field.

@shana shana added this to the 1.0.99.5 milestone May 26, 2016

grokys added a commit that referenced this issue May 30, 2016

Removed DefaultRepositoryName
From `IRepositoryPublishViewModel`. Seems to not be needed and was
causing #279.

The default repository name was being placed directly into
`RepositoryPublishControl.nameText` in the control which meant:

- it was only written to `RepositoryName` when the user clicked on the
`nameText` control
- which meant that `RepositoryName` was up until that point null
- which meant that the validation for it was failing
- which meant the "Publish" button was disabled.

This commit just sets the `RepositoryName` to the default in the VM ctor
meaning that that name gets immediately validated.
`DefaultRepositoryName` didn't seem to be used anywhere else, so I
removed it.

cc: @Haacked for a sanity check because it looks like you wrote this.

Fixes #279

@shana shana closed this in #337 Jun 2, 2016

@shana shana modified the milestones: 1.0.99.5, 1.0.99.6 Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment