[WIP] Support direct connectivity to cluster nodes and simplify SSH configuration #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snh
changed the title
Unifies the approach taken by the backup scripts (which doesn't get the hostname from the command-line), and restore (which do).
buckelij
reviewed
Jun 11, 2018
| @@ -75,7 +60,7 @@ for hostname in $hostnames; do | |||
|
|
|||
| # Transfer all data from the user data directory using rsync. | |||
| ghe-rsync -avz \ | |||
| -e "ssh -q $opts -p $port $ssh_config_file_opt -l $user" \ | |||
| -e "ghe-ssh" \ | |||
There was a problem hiding this comment.
This is great ✨ . $port is currently derived from ssh_port_part, which returns port 22 by default. Switching this to ghe-ssh will prevent some cases where ghe-backup-pages (and some other scripts) try to connect to the wrong port.
This comment has been minimized.
This comment has been minimized.
dooleydevin
pushed a commit
that referenced
this pull request
Jul 14, 2023
Update 3.9 version to be 3.9 and not 3.8 - seems the backward sync was missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent feature
https://github.com/github/ghes-infrastructure/issues/376
This is a work in progress. Further details and tests to come...
/cc @github/backup-utils