Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Max Schaefer committed Jan 24, 2020
1 parent ebea811 commit c30b1d9
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion ql/examples/snippets/constant.ql
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ import go

from DataFlow::Node zero
where zero.getNumericValue() = 0
select zero
select zero
5 changes: 2 additions & 3 deletions ql/examples/snippets/fieldread.ql
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@

import go

from Type reqtp, Field reqm, DataFlow::Read read
from Field reqm, Read read
where
reqtp.hasQualifiedName("net/http", "Request") and
reqm = reqtp.getField("Method") and
reqm.hasQualifiedName("net/http", "Request", "Method") and
read = reqm.getARead()
select read
5 changes: 2 additions & 3 deletions ql/examples/snippets/fieldwrite.ql
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@

import go

from Type response, Field status, DataFlow::Write write
from Field status, Write write
where
response.hasQualifiedName("net/http", "Response") and
status = response.getField("Status") and
status.hasQualifiedName("net/http", "Response", "Status") and
write = status.getAWrite()
select write, write.getRhs()
6 changes: 3 additions & 3 deletions ql/examples/snippets/type.ql
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@

import go

from Type response
where response.hasQualifiedName("net/http", "Request")
select response
from Type request
where request.hasQualifiedName("net/http", "Request")
select request
2 changes: 1 addition & 1 deletion ql/examples/snippets/varread.ql
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import go

from Variable err, DataFlow::Read read
from Variable err, Read read
where
err.getName() = "err" and
read = err.getARead()
Expand Down
2 changes: 1 addition & 1 deletion ql/examples/snippets/varwrite.ql
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import go

from Variable err, DataFlow::Write write
from Variable err, Write write
where
err.getName() = "err" and
write = err.getAWrite()
Expand Down

0 comments on commit c30b1d9

Please sign in to comment.