Bazel: Use new packaging rules #16623
Conversation
criemen
added
the
depends on internal PR
go/BUILD.bazel
Outdated
| env = {"REPO_NAME": repo_name()}, | ||
| main = "create_extractor_pack.py", | ||
| deps = ["_extractor_pack"], | ||
| install_dest = "build/codeql-extractor-pack", |
There was a problem hiding this comment.
@mbg are you particularly attached to this installation destination? If we can go with the default (which would be go/extractor-pack) it would be consistent with other languages already using that (ruby, ql and swift), and we could go for a generic */extractor-pack/qlpack.yml include in codeql-workspace.yml and a generic /*/extractor-pack exclude in .gitignore.
There was a problem hiding this comment.
I am not aware of any reason why this has to be codeql-extractor-pack. I suspect it may just be an inconsistency from when the Go extractor lived in a separate repository. It should be fine to change this to be the same as for other languages. CC @smowton @owen-mc in case they have any insights I don't have.
It turns out we still need to supply this option, so `codeql` goes looking for the extractor paths specified in the `codeql-workspace.yml` file.
This PR updates the external repo to use the new packaging rules introduced in #16432. This removes a rather large dependency on the internal build.
Depends on #16622, and will have to be rebased on top of
mainonce that PR has landed.No approval from the individual language teams is required, as this is a purely packaging-related PR that doesn't touch any implementation.