Javascript: use codeql_pack for javascript extractor
#16656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
reviewed
Jun 4, 2024
| @@ -0,0 +1,94 @@ | |||
| name: "javascript" | |||
There was a problem hiding this comment.
I assume this file and the scripts in the tools folder are copied unchanged from the internal repository and will be removed from the internal repository in the near future?
There was a problem hiding this comment.
Yes exactly, only a CONTRIBUTING.md file was dropped. I'm not sure what it did there in the first place tbh.
aibaars
approved these changes
Jun 4, 2024
criemen
added a commit
that referenced
this pull request
Jun 4, 2024
This was missing in #16656, so we couldn't actually delete the resources in the internal repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last language that still needs converting to the new packaging framework.
Incidentally, this contains some small fixes for other languages that I just spotted, too.
This is a follow-up to #16623.