Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Security advisory credit" & "Discussion answered" to "Displaying badges on your profile" #17870

Merged
merged 7 commits into from
Jun 1, 2022

Conversation

Schweinepriester
Copy link
Contributor

@Schweinepriester Schweinepriester commented May 15, 2022

Why:

Closes #12556.

What's being changed:

Add two entries missing from the "Displaying badges on your profile" section.

The octicons I grabbed by inspecting the source on the two mentioned example profiles and verified at

Links used in the code for convenience

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
    • Done, looking good!
  • For content changes, I have completed the self-review checklist.
    • I have checked the linked checklists and I think I'm compliant, but not totally sure.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented May 15, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@steveward
Copy link
Member

Thanks @Schweinepriester, I'll get this triaged for review.

@steveward steveward added waiting for review Issue/PR is waiting for a writer's review content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels May 18, 2022
@Mohasinkhan674

This comment was marked as spam.

@jules-p jules-p added the ready to merge This pull request is ready to merge label Jun 1, 2022
@docubot docubot added this to Triage in Docs open source board Jun 1, 2022
@jules-p
Copy link
Contributor

jules-p commented Jun 1, 2022

Hi @Schweinepriester 👋🏻 Thank you for opening this pull request, and for the super clear issue preceding it 💖 I've made a couple of tiny tweaks to the wording, and now it's ready to merge. We'll get that done for you shortly. Thanks again ✨

Copy link
Contributor

@jules-p jules-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🚀 🎇

@janiceilene janiceilene merged commit ea062fd into github:main Jun 1, 2022
Docs open source board automation moved this from Triage to Done Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@Schweinepriester Schweinepriester deleted the patch-2 branch June 1, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
No open projects
5 participants