Mention that GITHUB_* and RUNNER_* can't be set using GITHUB_ENV (but that CI can be)
#20069
Conversation
…` (but that `CI` can be)
github-actions
bot
added
the
triage
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
jsoref
changed the title
GITHUB_* and RUNNER_* can't be set using `GITHUB_ENV…GITHUB_* and RUNNER_* can't be set using GITHUB_ENV (but that CI can be)
|
👋 @jsoref Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
cmwilson21
added
content
martin389
added
the
needs SME
|
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
|
This is a gentle bump for the docs team that this PR is waiting for technical review. |
There was a problem hiding this comment.
@jsoref - Many thanks for raising this PR. Apologies it has taken a long time to review and merge it.
I've reworded the reusable a little and added links outside of the reusable.
I'll go ahead and apply those changes so that we can get this merged now.
Thanks again for your help. 🙇
content/actions/using-workflows/workflow-commands-for-github-actions.md
Outdated
Show resolved
Hide resolved
|
Unfortunately, due to us taking so long to review this, there are now conflicts in these files which need resolved before we can merge this:
|
|
@hubwriter: can you deal w/ them? I'm unlikely to know the context of those changes. If things are simple enough, I can do a rebase and reapply the spirit of the current head of this branch... |
There was a problem hiding this comment.
@jsoref - There are a couple of simple changes need to avoid the conflicts in this PR.
- One of the files was renamed, but the same change can be made in the renamed file.
- A subheading has been changed in the current version of the docs.
I've marked these inline on the diff.
| @@ -124,6 +124,8 @@ Any new environment variables you set that point to a location on the filesystem | |||
|
|
|||
| The default environment variables that {% data variables.product.prodname_dotcom %} sets are available to every step in a workflow. | |||
|
|
|||
| {% data reusables.actions.environment-variables-are-fixed %} For more information about setting environment variables, see "[AUTOTITLE](/actions/learn-github-actions/variables#defining-environment-variables-for-a-single-workflow)" and "[AUTOTITLE](/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable)." | |||
There was a problem hiding this comment.
The environment-variables.md file is now called variables.md. After merging main from upstream into your issue-19626 branch you can make the above insertion into the same place in the variables.md file and delete environment-variables.md.
| @@ -580,6 +580,8 @@ echo "{environment_variable_name}={value}" >> $GITHUB_ENV | |||
|
|
|||
| You can make an environment variable available to any subsequent steps in a workflow job by defining or updating the environment variable and writing this to the `GITHUB_ENV` environment file. The step that creates or updates the environment variable does not have access to the new value, but all subsequent steps in a job will have access. The names of environment variables are case-sensitive, and you can include punctuation. For more information, see "[Environment variables](/actions/learn-github-actions/environment-variables)." | |||
|
|
|||
| {% data reusables.actions.environment-variables-are-fixed %} For more information about the default environment variables, see "[AUTOTITLE](/actions/learn-github-actions/environment-variables#default-environment-variables)." | |||
|
|
|||
| ### Example | |||
There was a problem hiding this comment.
The current text of this subheading is:
| ### Example | |
| ### Example of writing an environment variable to `GITHUB_ENV` |
Changing this will avoid a conflict.
|
@jsoref - I don't have write access to your fork of the docs repo, so I can't fix up the conflicts. I'll close this PR and make the same changes on a new PR. |
Why:
Closes #19626
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adding note about default vars immutability.
https://docs-20069-a70e64.preview.ghdocs.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
https://docs-20069-a70e64.preview.ghdocs.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable
Check off the following:
Writer impact (This section is for GitHub staff members only):