Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA #172

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Add PWA #172

merged 1 commit into from
Feb 15, 2018

Conversation

abraham
Copy link
Member

@abraham abraham commented Feb 15, 2018

I am:

  • Suggesting edits to an existing Topic page
  • Curating a new Topic page

EDITING AN EXISTING TOPIC PAGE*

I'm suggesting these edits to an existing topic:

  • Image (and my file is *.png, square, dimensions 288x288)
  • Content (and my changes are in index.md)

Please explain why these changes are necessary:

CURATING A NEW TOPIC PAGE

  • I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:

PWAs are rapidly being added to many SPA frameworks out of the box or with starter kits.

Image is CC0

@MikeMcQuaid MikeMcQuaid merged commit 95982c2 into github:master Feb 15, 2018
@MikeMcQuaid
Copy link
Contributor

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @abraham!

@abdonrd
Copy link

abdonrd commented Feb 15, 2018

I'm with @kenchris. Maybe it would be better to remove the created_by field.

@kenchris
Copy link

It would be nice to educate people better though

@MikeMcQuaid
Copy link
Contributor

@kenchris Will happily accept PRs to update the created_by field.

@abraham abraham deleted the pwa branch February 15, 2018 18:43
@kenchris
Copy link

@MikeMcQuaid Is the best way to just remove the created_by or could we refer to a link, like say wikipedia instead?

@TalAter
Copy link
Contributor

TalAter commented Feb 15, 2018

I think @kenchris raises a very valid point.

I have created a PR for this (#173) and explained my reasoning in (great) detail.

And let me also thank @abraham for taking the time to create this topic. 🎉 :octocat:

@abraham
Copy link
Member Author

abraham commented Feb 15, 2018

Awesome @TalAter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants