Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added twostraws/Ignite to the collection of static-site-generators #4346

Merged
merged 6 commits into from
May 28, 2024

Conversation

jobearrr
Copy link
Contributor

@jobearrr jobearrr commented May 25, 2024

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

nguyenquangminh0711/ruby_jard has been renamed to 0x2c7/ruby_jard

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Ignite is becoming a popular static site generator in Swift. This will be the first static site generator in swift in this list

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@jobearrr jobearrr marked this pull request as ready for review May 25, 2024 04:50
@jobearrr jobearrr requested a review from a team as a code owner May 25, 2024 04:50
@jobearrr
Copy link
Contributor Author

jobearrr commented May 25, 2024

I don't know what I'm doing wrong here...
First I got an error that a collection somewhere else I didn't change has been renamed and I must update it, so I do it.
Then I get an error that this new (updated) collection should be appended, at the end of the list, so I move it down to the end.
Then I get an error that the order of the collections shouldn't be changed.

Please help? 😅

Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for your contribution!

@kenyonj kenyonj enabled auto-merge May 28, 2024 14:21
@kenyonj kenyonj added this pull request to the merge queue May 28, 2024
Merged via the queue into github:main with commit 67c0e41 May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants