Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node/VisualStudio] ignore typings directory #2112

Merged
merged 5 commits into from
Feb 2, 2017

Conversation

bbodenmiller
Copy link
Contributor

Reasons for making this change:

Various tools now download these automatically

Links to documentation supporting these rule changes:

https://github.com/Microsoft/nodejstools/wiki/Automatic-Typings-Acquisition
https://code.visualstudio.com/docs/runtimes/nodejs#_intellisense-and-typings
https://github.com/typings/typings#usage

@shiftkey
Copy link
Member

@bbodenmiller with Typescript 2.0 moving away from typings to using node_modules for storing these files, this no longer seems important, right?

https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/

@bbodenmiller
Copy link
Contributor Author

I think it's going to take a bit of time before the typings directory is irreverent.

Node.gitignore Outdated
@@ -30,6 +30,7 @@ build/Release
# Dependency directories
node_modules
jspm_packages
typings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document this and indicate it's only relevant for Typescript pre-v2 projects?

@shiftkey shiftkey changed the title ignore typings directory [Node/VisualStudio] ignore typings directory Jan 29, 2017
@shiftkey
Copy link
Member

shiftkey commented Feb 2, 2017

@bbodenmiller I've just cleaned up things to get this in. Thanks!

@shiftkey shiftkey merged commit 5b15028 into github:master Feb 2, 2017
@bbodenmiller
Copy link
Contributor Author

👍

@bbodenmiller bbodenmiller deleted the patch-3 branch February 2, 2017 11:01
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
[Node/VisualStudio] ignore typings directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants