-
Notifications
You must be signed in to change notification settings - Fork 83.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Node/VisualStudio] ignore typings directory #2112
Conversation
@bbodenmiller with Typescript 2.0 moving away from https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/ |
I think it's going to take a bit of time before the |
Node.gitignore
Outdated
@@ -30,6 +30,7 @@ build/Release | |||
# Dependency directories | |||
node_modules | |||
jspm_packages | |||
typings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document this and indicate it's only relevant for Typescript pre-v2 projects?
@bbodenmiller I've just cleaned up things to get this in. Thanks! |
👍 |
[Node/VisualStudio] ignore typings directory
Reasons for making this change:
Various tools now download these automatically
Links to documentation supporting these rule changes:
https://github.com/Microsoft/nodejstools/wiki/Automatic-Typings-Acquisition
https://code.visualstudio.com/docs/runtimes/nodejs#_intellisense-and-typings
https://github.com/typings/typings#usage