Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative margin on featured-orgs class and static image #403

Closed
sonalkr132 opened this issue Sep 23, 2015 · 3 comments
Closed

Negative margin on featured-orgs class and static image #403

sonalkr132 opened this issue Sep 23, 2015 · 3 comments

Comments

@sonalkr132
Copy link
Contributor

Why is .featured-orgs has negative margin of 55px? Images are overflowing the screen because of it:
screenshot from 2015-09-23 09 54 17


Also why are these featured org avatars are stored in repo? Why isn't it using something like (check src property):

<img class="animate-in" src="https://github.com/{{ org }}.png" width="80" alt="View {{ org }}'s profile on GitHub">

Can I make above two changes?

@benbalter
Copy link
Contributor

Why is .featured-orgs has negative margin of 55px?

The intention was to show that there were lots and lots of government organizations on GitHub, and not just those featured. "So many they couldn't fit on the page"

Also why are these featured org avatars are stored in repo?

IIRC, it was a bandwidth consideration. There is no way to request a particular sized image using the [login].png route.

@sonalkr132
Copy link
Contributor Author

There is no way to request a particular sized image using the [login].png route.

@benbalter check out #404

A follow up question:
Can I please delete images from git history as well?
.git dir for this repo is just huge (21MB). There are many unused images in git history and assets/img/featured-orgs/* is only going to add up to that. I was having a slow internet day when I first cloned it and it took forever to complete.

EDIT:
Not a great idea 😝

@sonalkr132
Copy link
Contributor Author

closed with #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants